Skip to content

Missing argument 4 for Magento\GiftRegistry\Model\Plugin\QuoteItem::aroundConvert #4311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
OleksiyOleksiyovych opened this issue Apr 26, 2016 · 1 comment
Assignees

Comments

@OleksiyOleksiyovych
Copy link

Magento: EE 2.0.4.
Extension: GiftRegistry

Reproduce: I don't know how to reproduce this in standard Magento. But in our custom extension we are using following code for convert quote item to order item

/**@var \Magento\Quote\Model\Quote\Item\ToOrderItem */
protected $quoteItemToOrderItem;
...
$orderItem = $this->quoteItemToOrderItem->convert($quoteItem);

It worked in 2.0.2, but after update to 2.0.4 it generate warring:
Warning: Missing argument 4 for Magento\GiftRegistry\Model\Plugin\QuoteItem::aroundConvert() in ..../vendor/magento/module-gift-registry/Model/Plugin/QuoteItem.php on line 24

File: vendor/magento/module-gift-registry/Model/Plugin/QuoteItem.php
Function: aroundConvert

Please, change
public function aroundConvert( \Magento\Quote\Model\Quote\Item\ToOrderItem $subject, \Closure $proceed, \Magento\Quote\Model\Quote\Item\AbstractItem $item, $additional ) {

to

public function aroundConvert( \Magento\Quote\Model\Quote\Item\ToOrderItem $subject, \Closure $proceed, \Magento\Quote\Model\Quote\Item\AbstractItem $item, $additional = [] ) {

Thank you.

@ishakhsuvarov ishakhsuvarov self-assigned this Apr 26, 2016
@mazhalai
Copy link
Contributor

Please do not post EE issues here. Please post on the partner portal.
@ishakhsuvarov @MomotenkoNatalia Closing this issue since this is EE.

magento-engcom-team pushed a commit that referenced this issue Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants