Taxation details of order totals

[fooman]

Magento 1 does not save sufficient information for how it taxed shipping (along with other totals like giftwrapping, etc)

It looks like Magento 2 has the same issue. In the below code

Magento\Tax\Helper\Data

    if ($current && $source) {
        if ($current->getShippingTaxAmount() != 0 && $current->getBaseShippingTaxAmount() != 0) {
            $taxClassAmount[0]['tax_amount']        = $current->getShippingTaxAmount();
            $taxClassAmount[0]['base_tax_amount']   = $current->getBaseShippingTaxAmount();
            if ($current->getShippingHiddenTaxAmount() > 0) {
                $taxClassAmount[0]['hidden_tax_amount'] = $current->getShippingHiddenTaxAmount();
            }
            $taxClassAmount[0]['title']             = __('Shipping & Handling Tax');
            $taxClassAmount[0]['percent']           = null;
        }
    }

Magento should

1. be able to supply the tax percentage
2. be able to supply the correct tax rate name (instead of a generic Shipping and Handling Tax)

Overall I would propose looking into making totals first class citizens for taxation. In Magento 1 entries into sales_order_tax_item would be one approach.

[wshqq]

Like! This is important for the European Market.

[choukalos]

@fooman, @wshqq - would you be available for a conference call to discuss more? I'd like to better understand why you need these 2 items ( and any other's you might have ). I also have some questions around pricing algorithms for the European Market hopefully you can help with. If possible please contact me at cchoukalos at ebay dot com with times you are available next week. I'm US/Central Standard Time.

[wshqq]

@choukalos Have you recieved my email from my business email address?

[choukalos]

No I didn't - did you send it to this email or my work ( [email protected] ) ? When did you send it?

Thanks,
Chuck

Sent from my iPad

On Feb 25, 2014, at 1:22 PM, wshqq [email protected] wrote:

@choukalos Have you recieved my email from my business email address?

—
Reply to this email directly or view it on GitHub.

[wshqq]

I've send it to your work address last week. I will retry sending it.
 

Gesendet: Mittwoch, 26. Februar 2014 um 01:59 UhrVon: "Charles Choukalos" [email protected]: magento/magento2 [email protected]: wshqq [email protected]: Re: [magento2] Taxation details of order totals (#444)

No I didn't - did you send it to this email or my work ( [email protected] ) ? When did you send it?
Thanks,
Chuck
Sent from my iPad

On Feb 25, 2014, at 1:22 PM, wshqq [email protected] wrote:

@choukalos Have you recieved my email from my business email address?

—
Reply to this email directly or view it on GitHub.
—
Reply to this email directly or view it on GitHub.

[fooman]

I'll send this as email as well but the below is the easiest to showcase that this area needs some work. The screenshots are from dev45.

Given you have two different tax rates
tax rate 1 = 10%
tax rate 2 = 20%
And you place an order with 2 items taxed at 10% and shipping taxed at 20%
When you create 2 separate invoices with 1 item each
Then the displayed tax summaries should be correct

the order is correct

the detailed tax summary displays the order tax summary which is incorrect for both invoices

[choukalos]

Hi Kristoff,

The Magento 2 tax engine is from 1.7.0.2 / 1.12 code base slightly
swizzled. We changed our tax engine for 1.13.0 - 1.13.1 releases, with
some tweaks on 1.13.2; we plan on porting 1.13.2 to M2. Do you know if
this is still in 1.8.1 release? Regardless I'll ask the team about it.

Thanks,
Chuck

On Tue, Mar 4, 2014 at 6:08 PM, Kristof, Fooman [email protected]:

I'll send this as email as well but the below is the easiest to showcase
that this area needs some work. The screenshots are from dev45.

Given you have two different tax rates
tax rate 1 = 10%
tax rate 2 = 20%
And you place an order with 2 items taxed at 10% and shipping taxed at 20%
When you create 2 separate invoices with 1 item each
Then the displayed tax summaries should be correct

[image: order 100000003 -1]https://f.cloud.github.com/assets/455508/2328156/8081657a-a3f9-11e3-8484-3a3e192703c4.png
the order is correct

[image: order 100000003]https://f.cloud.github.com/assets/455508/2328141/4dd3de64-a3f9-11e3-81ef-a6b0ef103f51.png
the detailed tax summary displays the order tax summary which is incorrect
for both invoices

Reply to this email directly or view it on GitHubhttps://github.com//issues/444#issuecomment-36695478
.

---

From the Desk of: Chuck Choukalos

[fooman]

No improvement really

Also if you look at the invoice in the admin the issue is sidestepped only showing the 'Shipping & Handling Tax'

This is EE 1.13.1.0

[seansan]

Same issue here

Shipping taxt is also 21% (and used to be grouped with the 21% group)

Magento 1.8.1

[choukalos]

Expanded storage of tax info with new tax service; In effect since dev beta tagged release.