Order cancel api "/V1/orders/{order_id}/cancel" doesn't fail for completely invoiced order

[ruby10]

Hi there,
As per observation on Magento2.0 on back-end there is no "Cancel" option for the order which is invoiced completely, which goes as per logic. But If I make cancel call via api "/V1/orders/{order_id}/cancel" in response I am getting "true" ,which is not correct. According to my understanding we should not be allowed to make cancel call for such orders. Also , On making cancel call for already "cancelled" orders , we get "true" in response, instead of some error message.

[mujtaba2012]

It seems the API call always return true, even if the order is already cancelled or invoiced. Instead it should returning some error code.

[srinivasanithin]

Hi

I think this function in OrderService.php this function
`public function cancel($id)
{
$order = $this->orderRepository->get($id);
if ((bool)$order->cancel()) {
$this->orderRepository->save($order);
return true;
}

    return false;
}`

was using Order.php cancel which is always return order information even though canCancel() returns false.
` public function cancel()
{
if ($this->canCancel()) {
$this->getPayment()->cancel();
$this->registerCancellation();

        $this->_eventManager->dispatch('order_cancel_after', ['order' => $this]);
    }

    return $this;
}`

I think this is the issue

[ruby10]

@vzabaznov , @NadiyaS any update on it??

[RomanKrut]

@ruby10 Hi, thank you for your report. Internal ticket was created MAGETWO-70442.