Skip to content

On editing a Bundle product from shopping cart the user defined quantities of the options are overwritten #4942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
densen45 opened this issue Jun 9, 2016 · 5 comments
Closed

On editing a Bundle product from shopping cart the user defined quantities of the options are overwritten #4942

densen45 opened this issue Jun 9, 2016 · 5 comments
Labels
bug report Component: Checkout Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release triage wanted

Comments

@densen45
Copy link
Contributor

densen45 commented Jun 9, 2016

Steps to reproduce

  1. Install Magento CE 2.0.6
  2. Create a Bundle product with at least one option of type radio and enable user defined quantity
  3. Add more then one product to the option and enable user defined quantity
  4. Open the Bundle product on frontend
  5. Change the quantity of an option
  6. Add the Bundle product to the shopping cart
  7. Go to the shopping cart
  8. Press the "Edit" button in order to edit the Bundle product

Expected result

  1. The quantity of the option should be the user defined one

Actual result

  1. The quantity of the option is not the user defined one. It is the selections' default quantity.

Debugging until now

  1. On page load the quantity is the user defined one (see variable $_defaultQty in radio.phtml).
  2. Then the value (property, not the attribute) of the input field is changed through Javascript
  3. Don't know were this happens exactly but for sure the _onBundleOptionChanged(event) of the price-bundle.js is involved.
@densen45 densen45 changed the title On editing a Bundle product from shopping cart the quantities of the options are overwritten On editing a Bundle product from shopping cart the user defined quantities of the options are overwritten Jun 9, 2016
@RomanKrut
Copy link

Internal ticket was created for this issue - MAGETWO-69959

@veloraven veloraven added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Jun 19, 2017
@magento-engcom-team magento-engcom-team added bug report Component: Checkout Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed labels Sep 11, 2017
@magento-engcom-team magento-engcom-team added 2.2.x Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Oct 5, 2017
@magento-engcom-team
Copy link
Contributor

@densen45, thank you for your report.
We've created internal ticket(s) MAGETWO-69959 to track progress on the issue.

@jasperzeinstra jasperzeinstra mentioned this issue Mar 6, 2018
Closed
4 tasks
@magento-engcom-team
Copy link
Contributor

@densen45, thank you for your report.

Unfortunately, we are archiving this ticket now as it did not get much attention from both Magento Community and Core developers for an extended period. This is done in an effort to create a quality, community-driven backlog which will allow us to allocate the required attention more easily.

You may learn more about this initiative following this link.

Please feel free to comment or reopen the ticket if you think it should be reviewed once more. Thank you for collaboration.

@JosephMaxwell JosephMaxwell mentioned this issue Jun 6, 2018
Merged
4 tasks
magento-engcom-team pushed a commit that referenced this issue Oct 9, 2018
@epamt
MAGETWO-69959: [GitHub] On editing a Bundle product from shopping car…
4249d9a 
…t the user defined quantities of the options are overwritten #4942

- Added user defined quantities of bundle options to bundle json config
@magento-engcom-team
Copy link
Contributor

Hi @densen45. Thank you for your report.
The issue has been fixed in #15905 by @JosephMaxwell in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.8 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Oct 10, 2018
magento-engcom-team pushed a commit that referenced this issue Oct 10, 2018
@JosephMaxwell @dmanners
#4942: bundled products now retain customer selections when editing f…
076bb60 
…rom cart
magento-engcom-team added a commit that referenced this issue Oct 10, 2018
@magento-engcom-team
ENGCOM-2997: #4942 and bundle checkbox bug #15905
f597e73 
 - Merge Pull Request #15905 from JosephMaxwell/magento2:patch-2
 - Merged commits:
   1. c05ac4c
   2. 076bb60
   3. e35a9b1
magento-engcom-team pushed a commit that referenced this issue Oct 10, 2018
@nmalevanec
ENGCOM-2997: #4942 and bundle checkbox bug #15905. Fix functional and…
eabe665 
… static tests.
magento-engcom-team pushed a commit that referenced this issue Oct 10, 2018
ENGCOM-2997: #4942 and bundle checkbox bug #15905
533979f
gelanivishal pushed a commit to gelanivishal/magento2 that referenced this issue Oct 11, 2018
@JosephMaxwell @gelanivishal
magento#4942: bundled products now retain customer selections when ed…
53f5942 
…iting from cart
gelanivishal pushed a commit to gelanivishal/magento2 that referenced this issue Oct 11, 2018
@dmanners @gelanivishal
magento#4942: fix code styles in the app/code/Magento/Bundle/Block/Ca…
8050d50 
…talog/Product/View/Type/Bundle.php file
@gelanivishal gelanivishal mentioned this issue Oct 11, 2018
Merged
4 tasks
gelanivishal pushed a commit to gelanivishal/magento2 that referenced this issue Oct 11, 2018
@nmalevanec @gelanivishal
NGCOM-2997: magento#4942 and bundle checkbox bug magento#15905. Fix f…
0bd75c8 
…unctional and…
@sidolov
Copy link
Contributor

sidolov commented Nov 5, 2018

Hi @densen45. Thank you for your report.
The issue has been fixed in #18520 by @gelanivishal in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.1 release.

@sidolov sidolov added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Nov 5, 2018
magento-engcom-team added a commit that referenced this issue Nov 5, 2018
@magento-engcom-team
ENGCOM-3161: [Forwardport] #4942 and bundle checkbox bug #18520
83eac4e 
 - Merge Pull Request #18520 from gelanivishal/magento2:2.3-develop-PR-port-15905
 - Merged commits:
   1. e210b70
   2. 53f5942
   3. 8050d50
   4. 0bd75c8
magento-engcom-team pushed a commit that referenced this issue Nov 5, 2018
@nmalevanec
ENGCOM-3161: [Forwardport] #4942 and bundle checkbox bug #18520. Fix …
48446c6 
…functional tests.
magento-engcom-team pushed a commit that referenced this issue Nov 5, 2018
@nmalevanec
ENGCOM-3161: [Forwardport] #4942 and bundle checkbox bug #18520. Fix …
0fe329b 
…static tests.
magento-engcom-team pushed a commit that referenced this issue Nov 5, 2018
ENGCOM-3161: [Forwardport] #4942 and bundle checkbox bug #18520
d06f1c2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug report Component: Checkout Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release triage wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@andimov @veloraven @densen45 @okorshenko @vkorotun @rgoncharuk @sidolov @RomanKrut @magento-engcom-team