Skip to content

js-translation.json bugs | Issues when translating validation js messages #5217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Pigau opened this issue Jun 24, 2016 · 3 comments
Closed

Comments

@Pigau
Copy link

Pigau commented Jun 24, 2016

Hello,

I am on a Magento 2.0.2. My locale is french (fr_FR).

I have a custom theme which have its js-translation.json file.

I noticed two distinct errors.

  • First, a sentence which exists in the file is not translated on the front. But others sentences in this file are translated.
    Sentence not translated : "Please enter a valid email address (Ex: [email protected])."
    Sentence translated : "This is a required field."
  • Second error : I have another JS validation sentence which is "Please select one of the options." and I don't know why but it is not in the js-translation.json file.

I created a language package (which is working) and I added in this those lines :
"Please select one of the options.","Veuillez choisir une des options.",module,Magento_Translation
"Please select one of the options.","Veuillez choisir une des options.",component,Magento2_Base
"Please select one of the options.","Veuillez choisir une des options.",lib,lib/web/mage/validation.js

I tried reploying static content, even after removing the js-translation.json in app/design/mynamespace/mytheme/js-translation.json. This file is regenerated but unchanged.

So I read this ticket :#2056
And then I followed this page : http://www.vanderboon.net/wiki/Install_Test_Magento_2_Translation
But now, after I did the symlink, my file is not regenerating in app/design/mynamespace/mytheme/.
But the files in pub/static are regenerated, but they are still wrong.

Do you guys have any idea ?
Thanks

@wert2all wert2all self-assigned this Jun 24, 2016
@wert2all wert2all removed their assignment Jun 24, 2016
@dimasch
Copy link

dimasch commented Jun 24, 2016

+1 the same issue on 2.0.7 for generate theme translations. For separate modules is ok.

@veloraven
Copy link
Contributor

@Pigau is this issue still actual?
If it is and you think it to be an issue please format it according to the Issue reporting guidelines: with steps to reproduce, actual result and expected result.
If it was just a question please refer to the Community Forums or the Magento Stack Exchange as GitHub issue tracker is intended for technical issues only.

@veloraven
Copy link
Contributor

According to contributor guide, tickets without response for two weeks should be closed.
If this issue still reproducible please feel free to create the new one: format new issue according to the Issue reporting guidelines: with steps to reproduce, actual result and expected result and specify Magento version.

magento-engcom-team pushed a commit that referenced this issue Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants