Skip to content

Magento 2.1 Swatches on catalog and product page do not disable when out of stock and more... #5558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
PierAlex opened this issue Jul 9, 2016 · 9 comments
Labels
bug report Component: Catalog Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@PierAlex
Copy link

PierAlex commented Jul 9, 2016

Fresh 2.1 installation
More than one issue:

Steps to reproduce
Configure a product with swatch attributs e.g size and color
Set some quantity to 0, or leave it empty, for child products. (Is it correct that they are automatically saved as virtual product instead simple ones?)
image

First Issue
On Catalog product page
Expected result
Clicking on a color swatch, the size swatch(es) related to product(s) out of stock must be disabled (if it helps, before 2.10 it runs).
Same expected result when selecting the size swatch(es) (must disable color swatches for out of stock products related to that size)

Actual result
All swatches are selectable also if products are out of stock.
image
in the example above, S and L sizes must be disabled..

Second issue:
On catalog product page:
Steps to reproduce
Select Color and size swatches and add the product to the cart.

Expected result
The product is added to the cart from catalog page.

Actual result
Clicking on add to cart button opens the product page and a message show that you have to choose options as color and size in the example also if you already selected in the catalog page.
.
image

Third issue:
As the first issue described for catalog page, it happens also in product page: Clicking on color does not disable size for product(s) out of stock. Same for size versus color.
image

@vkorotun vkorotun removed the MX label Aug 4, 2016
@AVoskoboinikov AVoskoboinikov self-assigned this Sep 13, 2016
@AVoskoboinikov AVoskoboinikov added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Sep 13, 2016
@AVoskoboinikov
Copy link
Contributor

Hi @PierAlex

Thanks for reporting! As for "Second issue" we already have internal ticket #MAGETWO-47017 to fix this. As for other issues - I have created one more internal ticket #MAGETWO-58328 for fix. This issue will be closed after fixes.

Have a good day!

@AVoskoboinikov AVoskoboinikov removed their assignment Sep 14, 2016
mmansoor-magento pushed a commit that referenced this issue Nov 9, 2016
MAGETWO-54365 [GitHub] Bundle Products - The price calculation fails for user defined quantity #4446
MAGETWO-47017 [Github] Add Configurable Product To Cart from Category Page #2574 #5850 #5882 #6572 #5558 #4184
@rganin
Copy link
Contributor

rganin commented Nov 9, 2016

Fixed under MAGETWO-47017 ticket.

@rganin rganin closed this as completed Nov 9, 2016
@PierAlex
Copy link
Author

PierAlex commented Nov 9, 2016

Hello @rganin
You closed this issue but there is another ticket referenced to this issues:
#MAGETWO-58328
Is it also fixed?
Thanks.

@kevin-carroll-cl
Copy link

kevin-carroll-cl commented Feb 21, 2017

Hello @rganin , we are experiencing the issue described in #MAGETWO-58328 where out of stock swatch options are not disabled/struck through, is there any word on the progress of this issue?

Version: 2.1.2 Community
Behavior: Swatch options matching out of stock simple products are enabled and selectable. Behavior persists regardless of setting for admin configuration Catalog > Inventory > Display Out of Stock Products.

Thank you.

-- EDIT: Update: Just upgraded to 2.1.4 and this issue is resolved. Thank you.

@moderncodes
Copy link

moderncodes commented Oct 9, 2017

Hi, it seems Magento 2.2.0 still having this issue of displaying text swatches when products out of stock, following by the notification message "You need to choose options for your item.".
Is there a way to see the 2.1 fix, so I can apply it temporary in to my site?
Thank you.

@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Oct 9, 2017
@Accolore
Copy link

Accolore commented Nov 2, 2017

Confirm that under Magento 2.2.0 the bug is still present.
Hope to be fixed quickly or alternatively to find a fix...

@moderncodes
Copy link

Painful...
On our site, it ONLY works when product has 1(one) configurable attribute, in example: (Size: S, M, X, XL). So, when Medium out of stock, it will completely hide the swatch text.
But, once you add 2nd attribute (Colors: White, Red, Black), and of of those combo products out of stock (XL > Red), it still allows user to select the combo, but once user clicks "Add to Cart", message comes up saying "You need to choose options for your item."
Now, the only time swatch text disabled and shows cross-bar, is when you dissociate this out of stock (XL > Red) from configurable product, or completely delete this simple product from the system. Then, once user clicks on XL, Red color will be disabled.

So, I kind of already assuming that Magento dev not going to fix this issue, because when they trying to replicate this bug, they probably either not adding 2nd attribute, or testing the part which is not broken, or maybe because it not 100% broken.

So, all we got left to do is appreciate the free open source software, and hope one day one of the smart developers will find the fix and commit it to the magento git project.

@Accolore
Copy link

Accolore commented Nov 3, 2017

Fixed for 2.2.0 with this https://github.com/mjankiewicz/MagentoConfigurableProduct

@jahvi
Copy link

jahvi commented Feb 2, 2018

Can confirm @LAccorinti's extension fixes the issue for version 2.2.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Component: Catalog Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Development

No branches or pull requests