Skip to content

Shopping cart product options missing #5612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mengento opened this issue Jul 13, 2016 · 13 comments
Closed

Shopping cart product options missing #5612

mengento opened this issue Jul 13, 2016 · 13 comments
Labels
bug report Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@mengento
Copy link

Steps to reproduce

  1. Install Magento 2.1
  2. Add Customizable Options .
  3. Add Product to Shopping cart.
  4. Not change any attributes(Customizable Options ), save the product again,
  5. Refresh Shopping cart ,

Expected result

  1. Shopping car product options normal

Actual result

  1. Shopping car product options missing
  2. Product page Options Id Change

20160713172524

@veloraven veloraven self-assigned this Aug 4, 2016
@veloraven
Copy link
Contributor

@mengento thank you for your report.
Internal ticket MAGETWO-56410 was created for this issue.

@veloraven veloraven added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Aug 4, 2016
@veloraven veloraven removed their assignment Aug 4, 2016
@erikhansen
Copy link
Contributor

@veloraven This is a pretty serious issue and is affecting at least one of our M2 merchants. Can you provide an update on an estimated fix for this issue?

@erikhansen
Copy link
Contributor

@veloraven Do you have any update for me on this?

@mengento mengento changed the title Shopping car product options missing Shopping cart product options missing Oct 14, 2016
@manfrinm
Copy link
Contributor

manfrinm commented Nov 3, 2016

@veloraven news about this?

@manfrinm
Copy link
Contributor

manfrinm commented Mar 2, 2017

Hello, I've created this patch CustomOptions Patch that solve this issue and the Custom option ID issue #5931
The patch can be applied on CE 2.1.5 or 2.1.4 and on EE 2.1.5 or 2.1.4 but I've tested this patch only for Magento EE 2.1.5.
Hopes is helpful

@kaushalsutharhs
Copy link

@manfrinm : I'm getting error, Using CE 2.1.5

 Applying patches for magento/module-catalog
    https://raw.githubusercontent.com/Hevelop/magento2-patches/master/Patch-Magento_Catalog-M2.1.5-MAGETWO-56410-MAGETWO-56411-github-issues-5931-5612.patch (Fix: https://github.com/magento/magento2/issues/5612)
   Could not apply patch! Skipping.

@manfrinm
Copy link
Contributor

manfrinm commented Mar 8, 2017

@kaushalsutharhs I've try to apply the patch on Magento CE 2.1.4 and 2.1.5 base version, and it goes correctly. Try to execute with -vvv to get more information about it.
Anyway, I've talked with official magento's developers (EE support), and they told me that they are currently on development with the "official patch"

@kaushalsutharhs
Copy link

Hi @manfrinm , Thanks for the reply, I'm getting following error while applying patch.

Executing command (CWD): cd '/home/test/Projects/magento2project/vendor/magento/module-catalog' && GIT_DIR=. git apply --check '-p1' '/tmp/58c2415a1bd56.patch'
error: patch failed: Ui/DataProvider/Product/Form/Modifier/CustomOptions.php:112
error: Ui/DataProvider/Product/Form/Modifier/CustomOptions.php: patch does not apply

cd '/home/test/Projects/magento2project/vendor/magento/module-catalog' && GIT_DIR=. git apply --check '-p0' '/tmp/58c2415a1bd56.patch'
Executing command (CWD): cd '/home/test/Projects/magento2project/vendor/magento/module-catalog' && GIT_DIR=. git apply --check '-p0' '/tmp/58c2415a1bd56.patch'
error: b/Controller/Adminhtml/Product/Initialization/Helper.php: No such file or directory
error: b/Model/Product/Option/Repository.php: No such file or directory
error: b/Model/Product/Option/SaveHandler.php: No such file or directory
error: b/Model/Product/Option/Validator/Select.php: No such file or directory
error: b/Model/Product/Option/Value.php: No such file or directory
error: b/Model/ResourceModel/Product/Option.php: No such file or directory
error: b/Model/ResourceModel/Product/Option/Value.php: No such file or directory
error: b/Ui/DataProvider/Product/Form/Modifier/CustomOptions.php: No such file or directory

cd '/home/test/Projects/magento2project/vendor/magento/module-catalog' && GIT_DIR=. git apply --check '-p2' '/tmp/58c2415a1bd56.patch'
Executing command (CWD): cd '/home/test/Projects/magento2project/vendor/magento/module-catalog' && GIT_DIR=. git apply --check '-p2' '/tmp/58c2415a1bd56.patch'
error: Adminhtml/Product/Initialization/Helper.php: No such file or directory
error: Product/Option/Repository.php: No such file or directory
error: Product/Option/SaveHandler.php: No such file or directory
error: Product/Option/Validator/Select.php: No such file or directory
error: Product/Option/Value.php: No such file or directory
error: ResourceModel/Product/Option.php: No such file or directory
error: ResourceModel/Product/Option/Value.php: No such file or directory
error: DataProvider/Product/Form/Modifier/CustomOptions.php: No such file or directory


@sheldmandu
Copy link

We are also experiencing this issue. In addition to shopping cart options it also affects Reorder functionality. This is also a problem not just for custom options on simple products but also for bundle options, which should probably be raised as a separate issue.

@scottsb
Copy link
Member

scottsb commented Apr 14, 2017

@kaushalsutharhs: I had the same issue applying the patch. I have created an updated patch to fix the issue with CustomOptions.php and have further removed a number of other changes that @manfrinm made that are good but unnecessary for the actual fix (such as improving docblocks or clarifying variable names). This will hopefully make the patch more robust if Magento releases additional versions before fixing this bug.

@veloraven
Copy link
Contributor

This issue is fixed in internal ticket MAGETWO-57153.
It will be available in one of the nearest releases.

@scottsb
Copy link
Member

scottsb commented Jun 29, 2017

@veloraven, I couldn't find any commits mentioning that internal ticket number. Is this going to be released for 2.1.x or 2.2?

magento-team pushed a commit that referenced this issue Oct 3, 2017
magento-team pushed a commit that referenced this issue Oct 3, 2017
magento-team pushed a commit that referenced this issue Oct 3, 2017
magento-team pushed a commit that referenced this issue Oct 3, 2017
magento-team pushed a commit that referenced this issue Oct 3, 2017
magento-team pushed a commit that referenced this issue Oct 3, 2017
magento-team pushed a commit that referenced this issue Oct 3, 2017
@LiamKarlMitchell
Copy link

LiamKarlMitchell commented May 2, 2020

What version of Magento 2 was this fixed in officially?
I am still seeing it in a 2.2.0 store despite it being listed as fixed in that versions change notes...
When sending requests with the rest api...
Even when I specify the same option_id and option_type_id as what is in the db for that record.

mmansoor-magento pushed a commit that referenced this issue Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Development

No branches or pull requests

9 participants