Skip to content

Tier price and custom options give bad results #5774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yangsystem opened this issue Jul 23, 2016 · 10 comments
Closed

Tier price and custom options give bad results #5774

yangsystem opened this issue Jul 23, 2016 · 10 comments
Assignees
@marinagociu
Labels
bug report Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@yangsystem
Copy link

Steps to reproduce

  1. Create a product with base price
    image
  2. Create a tier price
    image
  3. Create 2 custom options
    image
    and
    image

The logic is that the client should send me a design file and I will engrave a pen with his design.
image

I have special prices for re-sellers.

Expected result

If I am logged as a re-seller I have the right price for the product but the wrong price for the special option (the option specify that if you want also engrave on the back of the pen you should pay for an extra engrave). In this case the price for "Personalizare pe ambele fete + 12,00 RON" should be "Personalizare pe ambele fete + 0,30 RON"
image

The price is OK in shopping cart with the +100% if you want both sides engraved in both cases "general" and "re-seller" tier price
image
@oserediuk
Copy link
Contributor

Hello! Please, provide your code base version

@yangsystem
Copy link
Author

2.1.0

image

@SilvanLaroo
Copy link

I also face this issue, is there already a fix?

@yangsystem
Copy link
Author

I don't know. I have purchased 2 extensions one for formula calculation and one for advanced product options and I do my work with them.

@SilvanLaroo
Copy link

I see. I think the problem is here: https://github.com/magento/magento2/blob/develop/app/code/Magento/Catalog/Model/Product/Option/Value.php#L227

This function uses the function getFinalPrice() that does not use the tier prices.

@IlnitskiyArtem
Copy link

@yangsystem Thanks for reporting this issue.
I've linked this GitHub issue to internal ticket MAGETWO-70082

@veloraven veloraven added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Jun 22, 2017
@magento-engcom-team magento-engcom-team added bug report Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed labels Sep 11, 2017
@magento-engcom-team magento-engcom-team added the Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed label Oct 6, 2017
@magento-engcom-team
Copy link
Contributor

@yangsystem, thank you for your report.
We've created internal ticket(s) MAGETWO-70082 to track progress on the issue.

@magento-engcom-team magento-engcom-team added 2.1.x Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Oct 6, 2017
@marinagociu
Copy link

I'm working on it #SQUASHTOBERFEST

@marinagociu marinagociu mentioned this issue Oct 19, 2017
Merged
4 tasks
@okorshenko okorshenko added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Dec 14, 2017
@okorshenko
Copy link
Contributor

Hi @yangsystem
The issue has been fixed and delivered in 2.2-develop branch. Will be available with upcoming patch release.

@magento-engcom-team
Copy link
Contributor

Hi @yangsystem. Thank you for your report.
The issue has been fixed in magento-engcom/magento2ce#1359 by @magento-engcom-team in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.0 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Feb 8, 2018
pdohogne-magento pushed a commit that referenced this issue Jul 28, 2020
@zakdma
Merge pull request #5774 from magento-tsg/MC-34941
e583544 
[TSG] MC-34941: [MFTF] Replace magentoCli calls with appropriate AG calls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marinagociu marinagociu

Labels
bug report Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@andimov @SilvanLaroo @veloraven @marinagociu @yangsystem @okorshenko @oserediuk @IlnitskiyArtem @magento-engcom-team