Skip to content

Broken HTML in base template file #6081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JoshuaSoileau opened this issue Aug 9, 2016 · 6 comments
Closed

Broken HTML in base template file #6081

JoshuaSoileau opened this issue Aug 9, 2016 · 6 comments
Labels
Area: Frontend bug report Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@JoshuaSoileau
Copy link

The HTML in the following file is broken:

app/code/Magento/Review/view/frontend/templates/form.phtml
line #25

Here is the line with broken HTML:

<legend class="label"><span><?php /* @escapeNotVerified */ echo __('Your Rating') ?><span></legend><br/>

Here is a link to said file

The second <span> tag should be a closing tag (</span>)

Preconditions

  1. Google Chrome web browser

Steps to reproduce

  1. View product page on frontend
  2. Inspect "Your Rating" text on review submission form
  3. View DOM markup for legend element

Expected result

  1. HTML markup in DOM should only contain 1 span tag

Actual result

  1. HTML markup contains 2 span tags, as the browser will course correct and close the tag itself.
    image
@AVoskoboinikov
Copy link
Contributor

Hello,

Thank you for reporting this issue. I have created ticket for it in our internal Jira (MAGETWO-57428). This issue will be closed after fix.

@andimov andimov added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Aug 23, 2016
@Ctucker9233
Copy link

I believe there is already a pull request that fixes this issue.

@veloraven veloraven removed their assignment Sep 2, 2016
@magento-engcom-team magento-engcom-team added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report Area: Frontend Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed labels Sep 11, 2017
@Igloczek
Copy link
Contributor

It's already fixed on develop branch - 5228cf7

@ishakhsuvarov
Copy link
Contributor

@Igloczek Thanks for backporting!

@magento-team
Copy link
Contributor

Internal ticket to track issue progress: MAGETWO-75319

@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Sep 20, 2017

@magento-engcom-team magento-engcom-team added Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line labels Sep 20, 2017
magento-engcom-team pushed a commit that referenced this issue Sep 2, 2020
[GraphQL] Partners Acceleration Program Contributions - 2.4-develop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend bug report Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Development

No branches or pull requests

9 participants