Skip to content

Frontend product sorting via POST? #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tzyganu opened this issue Sep 9, 2014 · 6 comments
Closed

Frontend product sorting via POST? #656

tzyganu opened this issue Sep 9, 2014 · 6 comments
Labels
Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@tzyganu
Copy link
Contributor

tzyganu commented Sep 9, 2014

This is more a question than an issue, but it might be an issue.
I asked the same thing on magento.stackexchange.
Is there a reason to why the frontend product list sorting is done via POST instead of GET?
In my opinion is more user friendly to have it via GET. This way the customer can bookmark a link or share it with the products already sorted his desired criteria.

@verklov verklov self-assigned this Sep 9, 2014
@verklov
Copy link
Contributor

verklov commented Sep 9, 2014

@tzyganu, athanks for reporting this! I will forward the ticket to the team.

@tzyganu
Copy link
Contributor Author

tzyganu commented Sep 9, 2014

@verklov So is this a bug or a feature? Or are you waiting for a response from the team?

@verklov verklov assigned choukalos and unassigned verklov Dec 12, 2014
@vpelipenko
Copy link
Contributor

Internal ticket: MAGETWO-28212

@vpelipenko vpelipenko added MX and removed TECH labels Feb 17, 2015
@choukalos
Copy link

Hi @tzyganu - this is on our radar for near term development ( within a month ). We got this feedback from our tech forum and have a few stories to address them ( + MAGETWO-31677 ). You'll notice that we weren't terribly consistent with our REST route naming in addition to the PUTs vs GETs for search.

Originally we went with PUT as we thought the search criteria query was too complex and could run over the 2k character limit that IE8 has. After feedback we decided to change them to GETs and put an epic in for post 2.0 GA to revise how we handle the search criteria parameter as it's a tad wordy to create a query with a mix of and's and or's. It would be (hint hint) awesome if someone wanted to submit a PR to make the search criteria parameter a bit more user friendly.

Closing since we've got this tracked internally and ready to be done by Dev RC.

@maksek maksek reopened this Feb 23, 2015
@vpelipenko vpelipenko added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Apr 21, 2015
@choukalos
Copy link

APIs have been changed to be GET's from PUT's for list operations. Dropping myself from the assignee list.

@choukalos choukalos removed their assignment May 11, 2015
magento-team pushed a commit that referenced this issue Oct 1, 2015
@tzyganu
Copy link
Contributor Author

tzyganu commented Mar 3, 2016

It looks like this is changed to GET requests now. I'm closing the issue. In case someone has something else to add, or I missed something, this can be reopened.

@tzyganu tzyganu closed this as completed Mar 3, 2016
okorshenko pushed a commit that referenced this issue Dec 14, 2016
[Fiwi] Fix of Backward incompatible changes - 2.1.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Development

No branches or pull requests

5 participants