Skip to content

Minicart empty if FPC disabled in Magneto 2.1.1 #6882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ivanweiler opened this issue Oct 5, 2016 · 11 comments
Closed

Minicart empty if FPC disabled in Magneto 2.1.1 #6882

ivanweiler opened this issue Oct 5, 2016 · 11 comments
Labels
bug report Component: Checkout Component: Framework/Cache Fixed in 2.2.x The issue has been fixed in 2.2 release line Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@ivanweiler
Copy link

ivanweiler commented Oct 5, 2016

Preconditions

  1. Magento 2.1.1 with sample data
  2. Page Cache (FPC) disabled in admin

Steps to reproduce

  1. add product to cart
  2. switch currency, or switch language, or navigate to login and try to login with invalid user/pass

Expected result

  1. product should be in minicart

Actual result

  1. mini cart is empty
  2. customer can't proceed to checkout

Additional comment

Something is wrong with invalidation of local storage data. Local storage becomes empty and won't refresh when FPC is disabled (possible reason is that private_content_version cookie is missing and js reacts to it).

Funny thing is ..
FPC disabled - customer can't buy, but currency switcher works
FPC enabled - customer can buy, but you can't switch currencies on frontend as reported in #6746

Customers are unable to proceed to checkout and purchase if we need to temporary disable FPC on live site for some reason.

Thx

@Tjitse-E
Copy link
Contributor

Tjitse-E commented Oct 6, 2016

I've noticed the same issue, but this was on a Magento 2.1 site.

@ihor-sviziev
Copy link
Contributor

ihor-sviziev commented Oct 6, 2016

Looks like it's the same issue as #6473.
@ivanweiler could you check if this issue still reproduce after applying my patch from that Pull request?

@sevos1984 sevos1984 self-assigned this Oct 21, 2016
@sevos1984
Copy link
Contributor

Thanks for reporting, internal ticket created MAGETWO-59955

@sevos1984 sevos1984 added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Oct 21, 2016
@erikhansen
Copy link
Contributor

@ihor-sviziev I just tested the patch from your PR and I can verify that it fixed the described issue.

@SantoDE
Copy link

SantoDE commented Oct 26, 2016

Is that possible linked to #4170 @sevos1984 ?

@sidolov
Copy link
Contributor

sidolov commented Oct 28, 2016

Hi guys, this issue already fixed in develop branch, commit: 861f596

@sevos1984 sevos1984 removed their assignment Oct 31, 2016
@ihor-sviziev
Copy link
Contributor

@sidolov I think this issue can't be fixed in this way, because there also issue on client side (JS)

@Dublerq
Copy link

Dublerq commented Nov 7, 2016

Bug still present in 2.1.2. Let's make magento work with cashes! Natively! And tell them to use caches all they long. Who cares about devs

@sevos1984
Copy link
Contributor

Internal ticket id MAGETWO-60241

@magento-team
Copy link
Contributor

Internal ticket to track issue progress: MAGETWO-70218

@magento-engcom-team magento-engcom-team added 2.1.x Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report Component: Framework/Cache Component: Checkout Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed labels Sep 11, 2017
@magento-engcom-team
Copy link
Contributor

Fixed in MAGETWO-53766. Release 2.2.0
@ivanweiler thank you for report

@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Sep 20, 2017
magento-engcom-team pushed a commit that referenced this issue May 26, 2021
[Arrows] Fixes for 2.4 (pr148) (2.4-develop)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Component: Checkout Component: Framework/Cache Fixed in 2.2.x The issue has been fixed in 2.2 release line Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Development

No branches or pull requests