-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Do not use _addContent in controllers #699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for your suggestion! We will review it and get back to you once we have the answer. |
Internal ticket: MAGETWO-30487 |
Thank you for your submission. We recently made some changes to the way we process GitHub submissions to more quickly identify and respond to core code issues. Feature Requests and Improvements should now be submitted to the new Magento 2 Feature Requests and Improvements forum (see details here). We are closing this GitHub ticket and have moved your request to the new forum. |
From Magento 1.x we have a lot controllers that use _addContent. This method is fires after running loadLayout. As result we haven't ability to use action directive from layout files to use some manipulations, as example change template file for block (described there).
I propose mark this method as deprecated and replace same places to layout updates.
List of this places:
https://github.com/magento/magento2/search?q=_addContent
The text was updated successfully, but these errors were encountered: