Skip to content

Do not use _addContent in controllers #699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ihor-sviziev opened this issue Oct 21, 2014 · 3 comments
Closed

Do not use _addContent in controllers #699

ihor-sviziev opened this issue Oct 21, 2014 · 3 comments
Labels
improvement Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@ihor-sviziev
Copy link
Contributor

From Magento 1.x we have a lot controllers that use _addContent. This method is fires after running loadLayout. As result we haven't ability to use action directive from layout files to use some manipulations, as example change template file for block (described there).

I propose mark this method as deprecated and replace same places to layout updates.

List of this places:
https://github.com/magento/magento2/search?q=_addContent

@verklov verklov self-assigned this Nov 8, 2014
@verklov
Copy link
Contributor

verklov commented Nov 8, 2014

Thanks for your suggestion! We will review it and get back to you once we have the answer.

@maksek maksek added the PS label Nov 12, 2014
@verklov verklov added the TECH label Dec 12, 2014
@vpelipenko
Copy link
Contributor

Internal ticket: MAGETWO-30487

@vpelipenko vpelipenko added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Mar 25, 2015
@vkorotun vkorotun removed the PS label Aug 4, 2016
@piotrekkaminski
Copy link
Contributor

Thank you for your submission.

We recently made some changes to the way we process GitHub submissions to more quickly identify and respond to core code issues.

Feature Requests and Improvements should now be submitted to the new Magento 2 Feature Requests and Improvements forum (see details here).

We are closing this GitHub ticket and have moved your request to the new forum.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Development

No branches or pull requests

6 participants