-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Category Top Navigation / Maximal Depth configuration not working #7543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for reporting this issue. Internal task MAGETWO-61422 has been created for this issue. |
It looks like this is the issue: I fixed it manually by setting this block argument: Don't know how to fix it because this function never get's called: |
Same error here using Magento EE 2.1.3. @PascalBrouwers solutions doesn't seems to work for me. |
Same in 2.1.4 |
Do we have any news on this? I am on 2.1.6 and I still have the problem. |
@ovsokolov, thank you for your report. |
@magento-engcom-team , can you tell me what will be done with this issue?
|
Issue remains in Magento 2.2. |
Hi @ovsokolov. Thank you for your report. The fix will be available with the upcoming patch release. |
Hi @engcom-backlog-nazar. Thank you for working on this issue.
|
Hi @ovsokolov The issue was re-tested and we can confirm that it was fixed on the 2.3 release branch. We closing this issue as fixed due to upcoming 2.3 release that will be available soon. |
While this has been fixed in 2.3, the fix doesn't seem correct. The level setting is applied as-is, so if you enter '1' as maximal depth, it filters on level 1, which is the root category, which is never shown, so to get the 'top categories' or any categories at all really, you have to enter 2 in the setting. In M1 the level filter was applied as 'settingvalue + 1'. |
@Floddy it is according to the documentation. So people who use the documentation are not being confused with what programmers think: https://docs.magento.com/m2/ce/user_guide/catalog/navigation-top.html |
@arnoudhgz The documentation doesn't explicitly state the correlation between level and depth, and the setting says 'Maximal Depth', not 'Maximum level'. In my opinion they're two different things. Depth for me is 'how deep the main menu should render' - and setting it to 1 to me means 'render one level', just like in M1. It also states that 'To limit the number of subcategories that appear in the top navigation, enter the number in the Maximal Depth field.' which could suggest entering 1 would show 1 set of subcategories. |
Category Top Navigation / Maximal Depth configuration not working
Preconditions
Steps to reproduce
Category 1
--Category 2
---- Category 3
Expected result
Actual result
The text was updated successfully, but these errors were encountered: