Default Store is always used when retrieving sequence value's for sales entity's.

[reztierk]

The getReservedOrderId function in /vendor/magento/module-quote/Model/ResourceModel/Quote.php and the _beforeSave function in \Magento\Sales\Model\ResourceModel\EntityAbstract are using getStore()->getGroup()->getDefaultStoreId(), when they should be using getStore()->getStoreId(). Causing orders placed on other storeviews to use the prefix/suffix/increment id and sequence tables of the default store.

Preconditions

1. Magento 2.1.5

Steps to reproduce

1. Setup a clean install of Magento 2.1.5 with sample data
2. Add a second store view to the default website
3. Place an order on the second store view

Expected result

1. An increment id using the prefix from the new store view, and an entry in the sequence_order_2 table

Actual result

1. An increment id using the prefix from the default store view, and an entry in the sequence_order_1 table

[jaykobi]

Those line were introduced two years ago:
f9559c2
MAGETWO-36935: Orders placed in different store views should not have duplicated IDs

But I don't see why, either. With sequences and the meta table I can precisely crontrol when which increment id is used. But getStore()->getGroup()->getDefaultStoreId() completely breaks this for multiple store views in one group.

One more in the long list of bugs that REALLY need to be fixed asap.
Thanks for reporting @reztierk.

[magento-engcom-team]

@reztierk, thank you for your report.
We've created internal ticket(s) MAGETWO-80977 to track progress on the issue.

[tdgroot]

I'm working on it #SQUASHTOBERFEST

[okorshenko]

Hi @reztierk
The issue has been fixed and delivered in 2.2-develop branch. Will be available with upcoming patch release.

[domeglic]

Was this fixed completely? Because one of the classes mentioned by @reztierk is still the same:
https://github.com/magento/magento2/blob/2.2-develop/app/code/Magento/Sales/Model/ResourceModel/EntityAbstract.php#L129

I can only reproduce the bug when creating an order without going through checkout though (integration test).

[magento-engcom-team]

Hi @reztierk. Thank you for your report.
The issue has been fixed in magento-engcom/magento2ce#1362 by @magento-engcom-team in 2.3-develop branch
Related commit(s):

• 4705e23
• 6d355e0
• 77f34cf
• 748ab4d
• 90f9d95
• 44ca24f
• f0b7f2b
• c3e1d93
• 4810755
• 4709a22
• a2b9fab
• ac7df33
• 245238d
• 2c153c3
• 48a72fa
• 625f685
• afa4516

The fix will be available with the upcoming 2.3.0 release.