Wrong Price Calculation with HHVM

[gewaechshaus]

There seems to be a bug with the price calculation MCE 1.9.1.0 when using HHVM 3.4.2 in fcgi mode, even with enabled

hhvm.enable_zend_sorting=1

See the related issue
facebook/hhvm#4630

*Tracked down -> Mage_Core_Helper_Data *

/**
 * Convert and format price value for specified store
 *
 * @param   float $value
 * @param   int|Mage_Core_Model_Store $store
 * @param   bool $format
 * @param   bool $includeContainer
 * @return  mixed
 */
public static function currencyByStore($value, $store = null, $format = true, $includeContainer = true)
{
    try {
        if (!($store instanceof Mage_Core_Model_Store)) {
            $store = Mage::app()->getStore($store);
        }
        echo $value.'<br />';
        $value = $store->convertPrice($value, $format, $includeContainer);
        die($value);
    }
    catch (Exception $e){
        $value = $e->getMessage();
    }

    return $value;
}

Output

1.4800
14.800.000,00 €

Prices are high atm :)

Will track it down deeper and inspect the convertPrice method.

[gewaechshaus]

Deeper trackdown -> Mage_Core_Model_Store

/**
 * Format price with currency filter (taking rate into consideration)
 *
 * @param   double $price
 * @param   bool $includeContainer
 * @return  string
 */
public function formatPrice($price, $includeContainer = true)
{
    if ($this->getCurrentCurrency()) {

          Zend_Debug::dump(Mage::app()->getLocale()); 
          Zend_Debug::dump($price); 
          Zend_Debug::dump($this->getCurrentCurrency()->format($price, array(), $includeContainer));

          die('somewhere over the rainbow');

          return $this->getCurrentCurrency()->format($price, array(), $includeContainer);
    }
    return $price;
}

Output

object(Mage_Core_Model_Locale)#77772 (4) {
 ["_defaultLocale":protected] => string(5) "de_DE"
 ["_locale":protected] => object(Zend_Locale)#79137 (1) {
   ["_locale":protected] => string(5) "de_DE"
 }
 ["_localeCode":protected] => string(5) "de_DE"
 ["_emulatedLocales":protected] => array(0) {
 }

}

float(1,48)
string(45) "<span class="price">14.800.000,00 €</span>"

[gewaechshaus]

It appears system-wide, so it has to be deeper in the core...
Call it the 10mio € bug.

Native number_format works as expected.

Zend_Debug::dump(number_format($price,2));

string(4) "1.48"

[gewaechshaus]

Damn, this looks like an issue with sprintf in
facebook/hhvm#3725

Mage_Directory_Model_Currency

  /**
 * Returns the formatted price
 *
 * @param float $price
 * @param null|array $options
 * @return string
 */
public function formatTxt($price, $options = array())
{
    if (!is_numeric($price)) {
        $price = Mage::app()->getLocale()->getNumber($price);
    }
    /**
     * Fix problem with 12 000 000, 1 200 000
     *
     * %f - the argument is treated as a float, and presented as a floating-point number (locale aware).
     * %F - the argument is treated as a float, and presented as a floating-point number (non-locale aware).
     */

     Zend_Debug::dump($price);
     $price = sprintf("%F", $price);
     Zend_Debug::dump('After sprintf- '.$price);

    if ($price == -0) {
        $price = 0;
    }
    return Mage::app()->getLocale()->currency($this->getCode())->toCurrency($price, $options);
}

Output
float(1,48)
string(23) "After sprintf- 1.480000"

[gewaechshaus]

Zend_Debug::dump(Mage::app()->getLocale()->currency());

object(Zend_Currency)#89761 (1) {
 ["_options":protected] => array(12) {
 ["position"] => int(8)
 ["script"] => NULL
 ["format"] => NULL
 ["display"] => int(2)
 ["precision"] => int(2)
 ["name"] => string(4) "Euro"
 ["currency"] => string(3) "EUR"
 ["symbol"] => string(3) "€"
 ["locale"] => string(5) "de_DE"
 ["value"] => int(0)
 ["service"] => NULL
 ["tag"] => string(11) "Zend_Locale"
  }
}

Options array
The following options are available

• 'position' => Position for the currency sign
• 'script' => Script for the output
• 'format' => Locale for numeric output
• 'display' => Currency detail to show
• 'precision' => Precision for the currency
• 'name' => Name for this currency
• 'currency' => 3 lettered international abbreviation
• 'symbol' => Currency symbol
• 'locale' => Locale for this currency
• 'value' => Money value
• 'service' => Exchange service to use
  • @var array
  • @see Zend_Locale

Will continue tomorow! Any related ideas, hints etc. would be nice...

[orlangur]

Is this bug reproducible in Magento 2? It seems to me that relevant place for Magento 1.x bug reports is http://www.magentocommerce.com/bug-tracking.

As for Magento 2, it is not fully compatible with HHVM currently, but should definitely become compatible some day.

[gewaechshaus]

Hi Vlad,

you are right. I posted it here cause i'm unsure if this bug is related to ZF and i know about the future plans with Magento 2 and HHVM. I also think that Alan said that there are no plans to move away from ZF. Another reason, i like github more than the official bug tracker at magentocommerce.com as it seems faster and more productive ;) Found that would be a better place than the hhvm repo.

But to keep things in order, i will also post it in the official bugtracker when things are more clear and reproducable to us. I would like to continue inspecting this and post my results here if there are no problems with that.

Regards,
Jan

[verklov]

We created the ticket int he internal tracker with ID: MAGETWO-32945. the team will work on it according to the priorities. Thank you!

[gewaechshaus]

Hey Sergey,

thanks. I'll keep you updated. Actually we tracked it down so deep, i
has to be related to ZF and the some of the currency formating methods.
Another thing in the background, it could be related to hhvm's parsing
of php money_format.
*
One thing we could clearly track: *
If this bug appends, the format of the each currency gets broken,
indepent of which currency you choose. For example, if you choose EUR
and Zend::dump a helper formated zero price in €, it will become 00,00€
instead of it's default 0,00€, the same shizzle happens with $ and so
on. With this fact in the background, i guess sprintf or some other
methods will fail and multiply the result with 10mio. We checked some
other stuff, the localization formats xml from the ZF locale are
included correctly. So what the f*** is happening here?

It happens in the back- and in frontend (you can clearly see this in DEV
systems dashboard as the stats are mostly at zero or switch the currency
programmaticaly in the FE)... All orders are multiplied with 10mio while
sales_flat_order is still ok. If you dump out the var, without any
formating, it's ok 2. So it's in fact related to localisation/currency
converting.

Kind regards,
Jan

We created the ticket int he internal tracker with ID: MAGETWO-32945.
the team will work on it according to the priorities. Thank you!

—
Reply to this email directly or view it on GitHub
#966 (comment).