Skip to content

[Question] Add jenkins-ci ant build.xml and tool configurations to repository #973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Vinai opened this issue Jan 15, 2015 · 10 comments
Closed

[Question] Add jenkins-ci ant build.xml and tool configurations to repository #973

Vinai opened this issue Jan 15, 2015 · 10 comments
Assignees
@maksek
Labels
feature request Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed

Comments

@Vinai
Copy link
Contributor

Vinai commented Jan 15, 2015

I assume the core team is using some kind of ci besides travis-ci.
If there there is an ant build.xml (plus the configurations for the tools), would it be possible to add them to the repository?
Otherwise, if there are none, would you be open to a PR?
@maksek
Copy link
Contributor

maksek commented Jan 15, 2015

We are using Bamboo, and several plans for different testing, but our build.xml (s) has specific env data, and the reason why we don't share.
Travis is public and thats where you can take a look.
If you have some specific question, and want example - let us know.

@Vinai
Copy link
Contributor Author

Vinai commented Jan 16, 2015

It just would be handy to have a local build.
Would you consider merging a PR for a generic jenkins build config?

@facundocapua
Copy link
Contributor

+1 to the idea of having a generic jenkins build config

@maksek
Copy link
Contributor

maksek commented Jan 16, 2015

@Vinai, sure - feel free to create PR config into dev/tools/jenkins/

@maksek maksek self-assigned this Jan 16, 2015
@Vinai
Copy link
Contributor Author

Vinai commented Jan 16, 2015

Thanks, probably will be until after the dev beta forum though. ⌚

@Vinai
Copy link
Contributor Author

Vinai commented Jul 8, 2015

Just a quick update. I've based a jenkins build config (as I do most of my build configs) on the template provided at http://jenkins-php.org/.
It currently includes running php -l, pdepend, phpcs, phpmd, phpdox and the unit and integration tests.
A build takes for ages to complete.
So in practice I keep all but the tests disabled.

I'm having a hard time to make up my mind. What do you think, should a jenkins build include all tools or only the unit and integration tests?

@maksek
Copy link
Contributor

maksek commented May 9, 2016

@Vinai, closing the feature request, since no progress on it. Let me know if you still up to this.

@maksek maksek closed this as completed May 9, 2016
@Vinai
Copy link
Contributor Author

Vinai commented May 10, 2016

Thanks Max. I've started to think that anybody who uses jenkins already has a working template that they adjust, and nobody who isn't familiar with jenkins would start using it because a build config was present. So no use adding and maintaining that.

fe-lix- pushed a commit to fe-lix-/magento2 that referenced this issue Apr 29, 2018
Merge pull request magento#973 from magento-engcom/851-fix-for-assosi…
f355146 
…ated-product-grid

MSI-851: Remove 'quantity_per_source' declaration from product_listin…
magento-engcom-team added a commit that referenced this issue Oct 13, 2019
@magento-engcom-team
ENGCOM-5989: GraphQl-972: added support of the Global scope in the co…
b1178fa 
…nfig fixture #973

 - Merge Pull Request magento/graphql-ce#973 from magento/graphql-ce:GraphQl-972-support-global-scope-in-the-config-fixture
 - Merged commits:
   1. 3489da5
   2. 63bd232
   3. b64a485
magento-engcom-team pushed a commit that referenced this issue Oct 13, 2019
@lenaorobei
ENGCOM-5989: GraphQl-972: added support of the Global scope in the co…
d60888d 
…nfig fixture #973
@magento-engcom-team
Copy link
Contributor

Hi @Vinai. Thank you for your report.
The issue has been fixed in #27138 by @drpayyne in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.0 release.

@magento-engcom-team magento-engcom-team added Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed labels Mar 12, 2020
@drpayyne
Copy link
Contributor

@magento-engcom-team, there's a bug when referencing issues cross repositories. The PR #27138 mentioned issue 978 from the adobe-stock-integration repository, but the bot thinks it's from magento2 repository. It would be great if this was fixed, thanks!

This was referenced May 9, 2022
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maksek maksek

Labels
feature request Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Vinai @facundocapua @maksek @drpayyne @magento-engcom-team