Skip to content

Magento\Test\Js\LiveCodeTest is failing because of reference to missing file in blacklist #10536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 16, 2017
Merged

Magento\Test\Js\LiveCodeTest is failing because of reference to missing file in blacklist #10536

merged 1 commit into from
Aug 16, 2017

Conversation

aheadWorks
Copy link

@aheadWorks aheadWorks commented Aug 15, 2017

Magento\Test\Js\LiveCodeTest is failing because of reference to missing file in blacklist

Description

Magento\Test\Js\LiveCodeTest is failing with exception: The following patterns didn't return any result:
module Magento_Checkout view/frontend/web/js/opcheckout.js

This file is not present in develop anymore, however the reference is still in blacklist:
dev/tests/static/testsuite/Magento/Test/Js/_files/jshint/blacklist/core.txt

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Aug 15, 2017

CLA assistant check
All committers have signed the CLA.

@ishakhsuvarov ishakhsuvarov added this to the August 2017 milestone Aug 15, 2017
@ishakhsuvarov
Copy link
Contributor

@aheadWorks Thank you for your PR.
Please note, that currently it is recommended to use eslint and jscs instead of jshint (support for it is going to be removed in the future).

@ishakhsuvarov ishakhsuvarov self-assigned this Aug 15, 2017
@magento-team magento-team merged commit 77e1a38 into magento:develop Aug 16, 2017
magento-team pushed a commit that referenced this pull request Aug 16, 2017
magento-team pushed a commit that referenced this pull request Aug 16, 2017
[EngCom] Public Pull Requests
 - MAGETWO-71578: Magento\Test\Js\LiveCodeTest is failing because of reference to missing file in blacklist #10536
 - MAGETWO-71544: Handle lifetime value 0 for form_key cookie #10528
 - MAGETWO-71542: Show shipping methods in shipping estimator as loading during estimation #10514
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants