Skip to content

Added ability to set 'rows' property for wysiwyg elements. #10732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 1, 2017

Conversation

vovayatsyuk
Copy link
Member

@vovayatsyuk vovayatsyuk commented Aug 31, 2017

Description

Read and apply rows property from config data for WYSIWYG fields.

Manual testing scenarios

  1. Open Category edit form in Magento backend
  2. As you see, Description field is very large and it has rows=20 property
  3. Open app/code/Magento/Catalog/view/adminhtml/ui_component/category_form.xml and find field settings. It has <item name="rows" xsi:type="number">8</item> config, but it does not work.
  4. Apply the patch and it will work.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Usage example:

```
<item name="config" xsi:type="array">
    <item name="formElement" xsi:type="string">wysiwyg</item>
    <item name="wysiwyg" xsi:type="boolean">true</item>
    <item name="rows" xsi:type="number">10</item>
</item>
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants