Skip to content

Protected getters and setters should be public #10792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Protected getters and setters should be public #10792

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions app/code/Magento/Catalog/Helper/Image.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -600,7 +600,7 @@ protected function getAngle()
* @param string $watermark
* @return $this
*/
protected function setWatermark($watermark)
public function setWatermark($watermark)
{
$this->_watermark = $watermark;
$this->_getModel()->setWatermarkFile($watermark);
Expand All @@ -612,7 +612,7 @@ protected function setWatermark($watermark)
*
* @return string
*/
protected function getWatermark()
public function getWatermark()
{
return $this->_watermark;
}
Expand All @@ -623,7 +623,7 @@ protected function getWatermark()
* @param string $position
* @return $this
*/
protected function setWatermarkPosition($position)
public function setWatermarkPosition($position)
{
$this->_watermarkPosition = $position;
$this->_getModel()->setWatermarkPosition($position);
Expand All @@ -635,7 +635,7 @@ protected function setWatermarkPosition($position)
*
* @return string
*/
protected function getWatermarkPosition()
public function getWatermarkPosition()
{
return $this->_watermarkPosition;
}
Expand All @@ -659,7 +659,7 @@ public function setWatermarkSize($size)
*
* @return string
*/
protected function getWatermarkSize()
public function getWatermarkSize()
{
return $this->_watermarkSize;
}
Expand All @@ -682,7 +682,7 @@ public function setWatermarkImageOpacity($imageOpacity)
*
* @return int
*/
protected function getWatermarkImageOpacity()
public function getWatermarkImageOpacity()
{
if ($this->_watermarkImageOpacity) {
return $this->_watermarkImageOpacity;
Expand All @@ -697,7 +697,7 @@ protected function getWatermarkImageOpacity()
* @param \Magento\Catalog\Model\Product $product
* @return $this
*/
protected function setProduct($product)
public function setProduct($product)
{
$this->_product = $product;
return $this;
Expand All @@ -708,7 +708,7 @@ protected function setProduct($product)
*
* @return \Magento\Catalog\Model\Product
*/
protected function getProduct()
public function getProduct()
{
return $this->_product;
}
Expand All @@ -730,7 +730,7 @@ public function setImageFile($file)
*
* @return string
*/
protected function getImageFile()
public function getImageFile()
{
return $this->_imageFile;
}
Expand Down Expand Up @@ -786,7 +786,7 @@ public function getOriginalSizeArray()
*
* @return \Magento\Framework\Config\View
*/
protected function getConfigView()
public function getConfigView()
{
if (!$this->configView) {
$this->configView = $this->viewConfig->getViewConfig();
Expand Down Expand Up @@ -844,7 +844,7 @@ public function getFrame()
* @param string $name
* @return string
*/
protected function getAttribute($name)
public function getAttribute($name)
{
return isset($this->attributes[$name]) ? $this->attributes[$name] : null;
}
Expand Down