Issue #5144 - fix add to cart product and validation required attribute for version CE 2.1 #10917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ishakhsuvarov
assigned VladimirZaets and omiroshnichenko and unassigned VladimirZaets and omiroshnichenko
Igloczek
reviewed
Sep 17, 2017
| @@ -28,7 +28,7 @@ | |||
| </div> | |||
| </div> | |||
| <?php endif; ?> | |||
| <div class="actions"> | |||
| <div class="actions siedem"> | |||
Igloczek
suggested changes
Sep 17, 2017
|
Also we have internal issue MAGETWO-70892 that currently resolved and in process of delivery. |
|
@omiroshnichenko I've tried to implement solution from the commit you had mentioned but it didn't work in 2.1. I think it requires more changes. So if we already have 2.2 released, we can close this issue |
|
My mistake. In updated 2.1-develop adding to cart using ajax and validation working fine. No more issue here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix add to cart product and validation required attribute for version CE 2.1
Description
While ajax add to cart on product page is enable, the validation of required arguments not working properly - is doubled, first it shows errors message in empty inputs, then reload the page.
In version 2.2. this problem doesn't appear.
Fixed Issues (if relevant)
#5144
Manual testing scenarios