[Backport 2.2-develop] PHP Livecodetest testCodeStyle() method does not use whitelist files#11376
Merged
magento-engcom-team merged 1 commit intomagento:2.2-developfrom Mar 11, 2018
Conversation
orlangur
approved these changes
Oct 11, 2017
a748689 to
e154d2e
Compare
e154d2e to
e8f2a70
Compare
…ed in phpunit xml config file
e8f2a70 to
86a9bcc
Compare
ihor-sviziev
approved these changes
Mar 6, 2018
Contributor
|
Hi @ihor-sviziev, thank you for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of PR#11362
\Magento\Test\Php\LiveCodeTest::testCodeStyle method does not use whitelist files, as it does \Magento\Test\Php\LiveCodeTest::testCodeMess. Because of that, it takes ages to complete when you only want to test code style for a few modified files.
With proposed changes, it will try to find whitelisted files, and if it does not find any, then full whitelist will be checked. By default the behaviour is the same, as long as you have the ability to limit processed files if you create whitelist files from outside.
Fixed Issues (if relevant)
Improvement
Manual testing scenarios
Contribution checklist