FIX #11022 in 2.1-develop: Filter Groups of search criteria parameter have not been included for further processing #11432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmanners
added
Release Line: 2.1
2.2.x
Reproduced on 2.1.x
dmanners
suggested changes
Oct 27, 2017
|
@davidverholen after testing this with 2.1 it does not actually seem to fix the issue. When you call the described API endpoints you still get all the data back. Unlike the 2.2 fix which showed only those that match the search. |
davidverholen
force-pushed
the
squashtoberfest-11022-2.1
branch
from
751ea43 to
525f90a
Compare
|
@dmanners the problem is, that the filters of the search criteria are ignored in the eav attribute repository getList function in 2.1. I've added a workaround which should fix this until it's replaced by the CollectionProcessor in 2.2 |
dmanners
reviewed
Nov 4, 2017
| @@ -212,7 +212,7 @@ public function testGetList() | |||
| $searchCriteriaMock = $this->getMock('\Magento\Framework\Api\SearchCriteriaInterface'); | |||
|
|
|||
| $filterGroupMock = $this->getMock('\Magento\Framework\Api\Search\FilterGroup', [], [], '', false); | |||
| $searchCriteriaMock->expects($this->once())->method('getFilterGroups')->willReturn([$filterGroupMock]); | |||
| $searchCriteriaMock->expects($this->exactly(2))->method('getFilterGroups')->willReturn([$filterGroupMock]); | |||
|
|
|||
| $filterMock = $this->getMock('\Magento\Framework\Api\Filter', [], [], '', false); | |||
| $filterGroupMock->expects($this->once())->method('getFilters')->willReturn([$filterMock]); | |||
There was a problem hiding this comment.
@davidverholen I think this is the method that needs to be called more than once in the tests.
dmanners
added
the
Reproduced on 2.3.x
okorshenko
pushed a commit
that referenced
this pull request
Nov 9, 2017
…teria parameter have not been included for further processing #11432
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Filter Groups and the Sort Order of the $searchCriteria parameter have not been included in the searchCriteria Object that is finally provided for the eav set repository.
This Pull request sets the filtergroups and sort order in the searchCriteriaBuilder
Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist
//cc @dmanners