Skip to content

Conversation

@sylvainraye
Copy link
Contributor

@sylvainraye sylvainraye commented Oct 14, 2017

…se of store code in url configured

Show a 404 error page if /admin is called but it was customized and the store code url is enabled

Description

When store code url is configured for frontend, the url admin is also involved to set the pathinfo but it should be not as it is a different expected area and that admin store code is "hard coded" in DB and PHP Class

Fixed Issues

  1. Going to '/admin' while using storecodes in url and a different adminhtml url will throw exception #11140: Going to '/admin' while using storecodes in url and a different adminhtml url will throw exception

Manual testing scenarios

  1. Everything is explained into Going to '/admin' while using storecodes in url and a different adminhtml url will throw exception #11140

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

sylvainraye and others added 2 commits October 14, 2017 15:01
@okorshenko okorshenko self-assigned this Oct 16, 2017
@okorshenko okorshenko added this to the October 2017 milestone Oct 16, 2017
@okorshenko okorshenko added Release Line: 2.2 2.2.x Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Oct 16, 2017
@okorshenko okorshenko merged commit 6ebf3ce into magento:2.2-develop Oct 18, 2017
okorshenko pushed a commit that referenced this pull request Oct 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Progress: accept Release Line: 2.2 Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants