-
Notifications
You must be signed in to change notification settings - Fork 9.4k
FR#7689_22 quote_address_id not copied when converting quote address to order address #11613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dmanners
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will need a new interface for BC reasons. Something like OrderQuoteAddressInterface should work here.
| * Gets the quote address ID for the order address. | ||
| * | ||
| * @return int|null Quote address ID. | ||
| */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately you cannot add these new methods to an interface without breaking BC http://devdocs.magento.com/guides/v2.2/contributor-guide/backward-compatible-development/index.html#introduction-of-a-method-to-a-class-or-interface in this case I would recommend adding a new interface to handle these new methods.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okey, i didnt know that policy, i will implement your solution and update the PR as soon as i a can. Thanks!! @dmanners
|
@mrodespin unfortunately the new methods to the class marked as |
When an order is created the quote address id are not saving in the order address table.
Description
I modified the place order function for save the quote_addres_id in order_address table properly. It was necessary to modify the Order Address Api interface for adding new getters and setters methods and Quote Management Model Logic.
Fixed Issues (if relevant)
Manual testing scenarios
With these modifications this field is saving properly.
Related PRs
#11614
Contribution checklist