Skip to content

Conversation

@mrodespin
Copy link
Contributor

@mrodespin mrodespin commented Oct 21, 2017

When an order is created the quote address id are not saving in the order address table.

Description

I modified the place order function for save the quote_addres_id in order_address table properly. It was necessary to modify the Order Address Api interface for adding new getters and setters methods and Quote Management Model Logic.

Fixed Issues (if relevant)

  1. quote_address_id not copied when converting quote address to order address #7689: quote_address_id not copied when converting quote address to order address

Manual testing scenarios

  1. Add products to the cart
  2. Place a guest order
  3. Check table order_address and detect that quote_addres_id is empty

With these modifications this field is saving properly.

Related PRs

#11614

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@dmanners dmanners self-assigned this Oct 26, 2017
@dmanners dmanners added this to the October 2017 milestone Oct 26, 2017
@dmanners dmanners added Release Line: 2.2 2.2.x bug report Component: Checkout Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Oct 26, 2017
Copy link
Contributor

@dmanners dmanners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need a new interface for BC reasons. Something like OrderQuoteAddressInterface should work here.

* Gets the quote address ID for the order address.
*
* @return int|null Quote address ID.
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately you cannot add these new methods to an interface without breaking BC http://devdocs.magento.com/guides/v2.2/contributor-guide/backward-compatible-development/index.html#introduction-of-a-method-to-a-class-or-interface in this case I would recommend adding a new interface to handle these new methods.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okey, i didnt know that policy, i will implement your solution and update the PR as soon as i a can. Thanks!! @dmanners

@dmanners
Copy link
Contributor

@mrodespin unfortunately the new methods to the class marked as @api cannot be done in a patch release so we cannot accept these changes to 2.2-develop and 2.1-develop. For these two releases you should be able to make the same changes with the extension attributes feature. For 2.3-develop the new methods and interface should be ok. Please feel free to make a new pull request using the extension attributes.

@dmanners dmanners closed this Nov 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug report bugfix Component: Checkout Progress: needs update Release Line: 2.2 Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants