Fixed order items list for order printing

[rogyar]

Description

The block class defined in the XML layout for order items on the order print page is definitely not correct. As result, you cannot see the order items information upon the order printing. The Magento\Sales\Block\Order\PrintShipment is not responsible for showing order items. By changing the block class to Magento\Sales\Block\Order\Items we will have the order items upon the order printing

Fixed Issues (if relevant)

1. Print order error on magento 2.1.8 #10530: Print order error on magento 2.1.8
2. Null order in Magento\Sales\Block\Order\PrintShipment.php #9830: Null order in Magento\Sales\Block\Order\PrintShipment.php

Manual testing scenarios

1. Place an order as a registered customer
2. Go to My Account -> My Orders. Open the order and click on the "Print Order" link
3. You should see all order's information for printing including the order items

[ricoliv]

We had same problem #10530 on Magento 2.1.9.
We hardcoded fix above in
$OURMAG2HOME/vendor/magento/module-sales/view/frontend/layout/sales_order_print.xml

Now printing order works as expected.

Beeing unfamiliar with Magento2 Upgrades we hope above .xml file will be replaced inxluding official fix automatically by next System Upgrade via Composer (part of magento core components).

[fooman]

thanks @rogyar for this pull request - I can confirm this fixes the issue of the missing items:

Before:

After:

Will add this to the queue of items to be merged.

[fooman]

@rogyar so far this PR will fix this issue in 2.1 branch. Can I ask you to also take a look at creating a separate PR for the 2.2 branch.

One further thing I noticed is that this seems to affect guest orders as well - see sales_guest_print.xml. If you could confirm that be great.

[okorshenko]

We need a PR for 2.2-develop branch

[rut4]

Also the same action for a guest should be fixed in vendor/magento/module-sales/view/frontend/layout/sales_guest_print.xml:20.