MAGETWO-81311: Check the length of the array before attempting to sli…

[briscoda]

…ce it. Slicing an array of one will create an empty result. Issue: 9944

Description

#9944

In the UI form element abstract.js, there is a case where the dataScope passed to the initConfig function may not have the string "data" appended to the name. In this case, performing a 'slice' on an array of 1 will create an empty result. In these cases, I have added a check to ensure that the array is at least greater than 1 before slicing, otherwise, use the result of splitting the scope variable.

In these cases you will always end of with something like:
["data_value"] or ["data_value", "data_value_two"]

Instead of a potential: [], which when used as the inputName would result in an empty input name attribute on the form element.

Fixed Issues (if relevant)

1. Name attribute shows empty when creating custom fields on product creation form #9944: Name attribute shows empty when creating custom fields on product creation form

Manual testing scenarios

1. Open the original Issue (Name attribute shows empty when creating custom fields on product creation form #9944)
2. Create a module with a product_form.xml ui component
3. Use a fieldname as a single string. (ie "placeholder")
4. View the field in the product create form and ensure that there is an html name element with the same value that is in the product_form.xml

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-cicd2]

All committers have signed the CLA.

[ihor-sviziev]

I think would be great to extract scope.split('.') to variable in order not to calculate it 3 times