Skip to content

[TASK] Moved Customer Groups Menu Item from Other settings to Customers #11652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

lewisvoncken
Copy link
Contributor

Description

Currently the Customer Groups are located in the Magento Admin under Stores > Other Settings > Customer Groups. But this is strange because in Magento 1 it was under Customers > Customer Groups

Manual testing scenarios

Before changes:
image

After changes:
image

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@okorshenko okorshenko self-assigned this Oct 24, 2017
@okorshenko okorshenko added this to the October 2017 milestone Oct 24, 2017
@okorshenko
Copy link
Contributor

@lewisvoncken thank you for PR. We need to approve this with PO
@tkacheva could you please approve this change?

@tkacheva
Copy link

@lewisvoncken Thank you for the contribution! That totally makes sense 👍🏻
@okorshenko, approved.

@okorshenko okorshenko merged commit aa1e778 into magento:2.3-develop Oct 25, 2017
okorshenko pushed a commit that referenced this pull request Oct 25, 2017
okorshenko pushed a commit that referenced this pull request Oct 25, 2017
AntonEvers pushed a commit to AntonEvers/magento2 that referenced this pull request Oct 26, 2017
* upstream/2.3-develop: (37 commits)
  MAGETWO-81033: Create GraphQL single product fetch endpoint  - Address static failure
  MAGETWO-81033: Remove unnecessary classes
  MAGETWO-81033: Create GraphQL endpoint for fetching single product  - Adds functional tests, fixtures, and client  - Adds support for simple and configurable product
  magento#11524: Fix Filter Customer Report Review  - Integration test updated
  MAGETWO-82561: [TASK] Moved Customer Groups Menu Item from Other settings to Customers magento#11652
  MQE-478: Deliver Pangolins Sprint 11
  MQE-478: Deliver Pangolins Sprint 11
  MQE-478: Deliver Pangolins Sprint 11
  magento#11522: Fix Filter Customer Report Review  - Integration test updated
  magento#11524: Fix Filter Customer Report Review  - Integration test added
  Fix Magento/Backend/Block/Media/Uploader.php getConfigJson() method, using undefined class property _coreData
  MAGETWO-77673: <![CDATA[]]>in system.xml translate phrase not work, if comment starts from new line[port from 2.2-develop].
  MQE-478: Deliver Pangolins Sprint 11
  MQE-440: metadata changes for path parameters bug fix.
  MQE-237: [Generator] Add before and after logic to suites
  MQE-394: Pre-Install Script
  MQE-440: Added configurable product related metadata, data, and a sample test.
  MQE-429: Added a sample test to perform api PUT request.
  MQE-453: [DevOps] Add optional arg for consolidated test run
  MQE-345: [DevOps] [Customizability] Create suite schema declaration and supporting interpretation
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants