Skip to content

magento/magento2#80862 Custom Product Attribute changes backend_type property #11715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

magento/magento2#80862 Custom Product Attribute changes backend_type property #11715

wants to merge 1 commit into from

Conversation

keyurshah070
Copy link
Contributor

Description

Fixed Issues (if relevant)

  1. Custom Product Attribute changes 'backend_type' when 'is_user_defined = 1' and get updated/saved in Admin Backend #9219: Custom Product Attribute changes 'backend_type' when 'is_user_defined = 1' and get updated/saved in Admin Backend
  2. User define product attribute backend type change from backend save.
  3. So if we have backend type as varchar(on Installer script) with its value in a string and after creating attribute when we update its property from backend then it changes backend type to integer. so we cannot save its attribute value on a product level

Manual testing scenarios

  1. Created Installer script with backendtype as varchar and change its property from backend and after saving attribute still, I have backendtype as varchar

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added 2.2.x Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Nov 7, 2017
@okorshenko okorshenko added this to the November 2017 milestone Nov 7, 2017
@omiroshnichenko
Copy link
Contributor

Hi, @keyurshah070. Could you please verify failed tests. Also you have opened concurrent PR #11837 that will have conflict with current. Can you, please, let us know if you would continue working on it or we should close it. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Progress: needs update Release Line: 2.2 Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants