Skip to content

[port 2.3-develop] Add missing translations in Magento_UI #11834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2017

Conversation

JeroenVanLeusden
Copy link
Member

Port of #11440. @fooman Can you check this since you also processed original PR?

Description

Add missing translations in UI module taken from mage/validation.js file.

Fixed Issues (if relevant)

  1. Untranslatable string "Please enter the same value again." #5956: Untranslatable string "Please enter the same value again."

Manual testing scenarios

  1. Install dutch language pack.
  2. Set locale of frontend to dutch.
  3. Create new user on the storefront, Fill both password fields with a different value.
  4. String should be translated.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added 2.2.x bugfix Area: Frontend Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Nov 7, 2017
@okorshenko okorshenko added this to the November 2017 milestone Nov 7, 2017
@okorshenko okorshenko merged commit c6bd471 into magento:2.3-develop Nov 16, 2017
@JeroenVanLeusden JeroenVanLeusden deleted the patch-9 branch December 4, 2017 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend bugfix Progress: accept Release Line: 2.3 Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants