Skip to content

Save the price 0 as price in custom options [backport 2.2] #11843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 31, 2017

Conversation

raumatbel
Copy link
Contributor

Related with the PR11842

Description

Possibility to save the price in custom options with value 0 or empty

Fixed Issues (if relevant)

  1. magento/magento2#<4808>: The price of product custom option can't be set to 0

Steps to reproduce

  1. Add an product custom option (Select Type)
  2. Add new row and set price greater than 0.
  3. Save product.
  4. Change the row price to 0 or empty.
  5. Save product.

Expected result

  1. The row price becomes 0.

Actual result

  1. The row price doesn't becomes 0.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@okorshenko okorshenko self-assigned this Oct 30, 2017
@okorshenko okorshenko added this to the October 2017 milestone Oct 30, 2017
@okorshenko okorshenko added Release Line: 2.2 2.2.x bug report Component: Catalog Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Oct 30, 2017
@okorshenko okorshenko merged commit ef464bd into magento:2.2-develop Oct 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Component: Catalog Progress: accept Release Line: 2.2 Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants