Skip to content

[2.1-develop] X-Magento-Tags header containing whitespaces causes exception #11848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 1, 2017
Merged

[2.1-develop] X-Magento-Tags header containing whitespaces causes exception #11848

merged 1 commit into from
Nov 1, 2017

Conversation

ihor-sviziev
Copy link
Contributor

@ihor-sviziev ihor-sviziev commented Oct 29, 2017 •
edited
Loading

Description

When the header X-Magento-Tags contains whitespaces, an Zend\Http\Header\Exception\InvalidArgumentException is being thrown when the full page cache is enabled. Block IDs can contain whitespaces due to reformatting in layout XML files, because of the 80 character line length limit.

(cherry picked from commit 026da5a)
Backport of #11767 to 2.1-develop

Fixed Issues (if relevant)

  1. X-Magento-Tags header containing whitespaces causes exception #7640: X-Magento-Tags header containing whitespaces causes exception

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@ihor-sviziev
Copy link
Contributor Author

@ishakhsuvarov original PR was processed by you, could you review this PR?

@ishakhsuvarov ishakhsuvarov self-assigned this Oct 30, 2017
@ishakhsuvarov ishakhsuvarov added this to the October 2017 milestone Oct 30, 2017
@ishakhsuvarov ishakhsuvarov added Release Line: 2.1 2.2.x bug report Component: Framework/Cache Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Oct 30, 2017
@okorshenko okorshenko modified the milestones: October 2017, November 2017 Nov 1, 2017
@okorshenko okorshenko merged commit 96cc453 into magento:2.1-develop Nov 1, 2017
okorshenko pushed a commit that referenced this pull request Nov 1, 2017
MAGETWO-82983: [2.1-develop] X-Magento-Tags header containing whitesp…
722c159 
…aces causes exception #11848
@ihor-sviziev ihor-sviziev deleted the patch-12 branch February 2, 2018 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ishakhsuvarov ishakhsuvarov

Labels
bug report Component: Framework/Cache Progress: accept Release Line: 2.1 Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
November 2017
Development

Successfully merging this pull request may close these issues.
5 participants
@ihor-sviziev @magento-team @ishakhsuvarov @okorshenko @nmalevanec