Skip to content

[BACKPORT 2.1] [BUGFIX] All UI input fields should have maxlength of 255 because of … #11918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

lewisvoncken
Copy link
Contributor

…VARCHAR maxlength 255 in the database

same as magento-partners/magento2ce#61

Description

When you save an input field in the Admin or Frontend area with a value greater then 255 characters the actual saved data in the database is 255 characters.

Fixed Issues (if relevant)

  1. Meta description allows too many characters #6238: Meta description allows too many characters

Manual testing scenarios

  1. Create a Test product
  2. Paste a string with more then 255 characters in the Meta Description or the Name
  3. Now the value is visible but after saving the value will be set to 255 characters

Apply Changes and Now it is possible to only insert 255 characters in the UI input fields

See the following image with the max length of 255 for the value column in the varchar column
image

@magento-engcom-team magento-engcom-team added 2.2.x bugfix Area: Frontend Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release labels Nov 7, 2017
@okorshenko okorshenko self-assigned this Nov 8, 2017
@okorshenko okorshenko added this to the November 2017 milestone Nov 8, 2017
@magento-engcom-team
Copy link
Contributor

@lewisvoncken Could you look at Meta Description field as maxlength: 255 not applied for it. This field has differences in v2.1 and v2.2
v2.1
image
v2.2
image

@magento-engcom-team magento-engcom-team added Fixed in 2.2.x The issue has been fixed in 2.2 release line Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Nov 10, 2017
@okorshenko
Copy link
Contributor

Hi @lewisvoncken
We are closing this PR for now. Feel free to reopen it once ready

@okorshenko okorshenko closed this Nov 16, 2017
@Ctucker9233
Copy link

@okorshenko I'll pick this up. I was the one who reported the original issue. What needs to be looked at?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend bugfix Fixed in 2.2.x The issue has been fixed in 2.2 release line Progress: needs update Release Line: 2.1 Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants