Skip to content

11792: Can't add customizable options to product #11965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 22, 2017
Merged

11792: Can't add customizable options to product #11965

merged 3 commits into from
Nov 22, 2017

Conversation

RomaKis
Copy link
Contributor

@RomaKis RomaKis commented Nov 2, 2017

Can't add customizable options to product

Description

If you add custom tab with a name "options" to product form via attribute set, data-index for this tab and options from custom-options will be the same, so I changed targetName from index to name.

Fixed Issues (if relevant)

  1. Can't add customizable options to product #11792: Can't add customizable options to product

Manual testing scenarios

  1. Go into the admin panel and navigate to Stores->Attribute Set
  2. Edit the default attribute set, add a new group named 'Options', add a few attributes to the new group, and save the group
  3. Navigate toe Products->Catalog and choose any product with the default attribute set to edit
  4. Expand the Customizable Options section and click the 'Add Option' button

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added 2.2.x Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Nov 7, 2017
@dmanners dmanners self-assigned this Nov 17, 2017
@dmanners dmanners added this to the November 2017 milestone Nov 17, 2017
@okorshenko okorshenko merged commit 311d409 into magento:2.2-develop Nov 22, 2017
@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Nov 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Release Line: 2.2 Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants