#11936:required attribute set id filter on attribute group repository getList #12105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzeis
reviewed
Nov 21, 2017
| @@ -117,16 +117,6 @@ public function save(\Magento\Eav\Api\Data\AttributeGroupInterface $group) | |||
| */ | |||
| public function getList(\Magento\Framework\Api\SearchCriteriaInterface $searchCriteria) | |||
| { | |||
| $attributeSetId = $this->retrieveAttributeSetIdFromSearchCriteria($searchCriteria); | |||
There was a problem hiding this comment.
@maghamed Since you requested the attribute set to be optional in #11936 (comment): are you fine with it being removed completely?
There was a problem hiding this comment.
magento-engcom-team
added
Reproduced on 2.1.x
mzeis
suggested changes
Dec 6, 2017
There was a problem hiding this comment.
@tzyganu Please can you do the change requested by @maghamed in https://github.com/magento/magento2/pull/12105/files#r155220528? Thanks!
|
@tzyganu Thanks for the change, don't worry! |
mzeis
approved these changes
Dec 20, 2017
magento-team
pushed a commit
that referenced
this pull request
Dec 22, 2017
…roup repository getList #12105
magento-engcom-team
added
the
Fixed in 2.2.x
|
@tzyganu Many thanks for your contribution. It has been merged. Happy holidays! 🎄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the need for an attribute_set_id filter in the method
Magento\Eav\Model\Attribute\GroupRepository::getListFixed Issues (if relevant)
Manual testing scenarios
Contribution checklist