Skip to content

Fix issue with special characters in email subject #12115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 9, 2017
Merged

Fix issue with special characters in email subject #12115

merged 2 commits into from
Nov 9, 2017

Conversation

ihor-sviziev
Copy link
Contributor

Description

Special characters in store name converted to numerical character references in email subject.

Fixed Issues (if relevant)

  1. Special characters in store name converted to numerical character references in email subject #8094: Special characters in store name converted to numerical character references in email subject
  2. Sales email subject "&" turns to   #6597: Sales email subject "&" turns to  

Manual testing scenarios

  1. Admin > Stores > General > General > Store Information > Store Name : change store name something having ampersand "&" like Easy&Piggy
  2. Send an order email.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Andrewb89 and others added 2 commits November 8, 2017 18:38
@Andrewb89 @ihor-sviziev
MAGETWO-63154: Special characters in store name converted to numerica…
653bfef 
…l character references in email subject

(cherry picked from commit e89d09d)
@arnie1947 @ihor-sviziev
MAGETWO-63154: Special characters in store name converted to numerica…
4133e11 
…l character references in email subject

- Integration test added.

(cherry picked from commit 750e1ad)
@okorshenko okorshenko self-assigned this Nov 8, 2017
@okorshenko okorshenko added this to the November 2017 milestone Nov 8, 2017
@okorshenko okorshenko added Release Line: 2.1 Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch and removed Can not Reproduce labels Nov 8, 2017
@okorshenko okorshenko merged commit 4133e11 into magento:2.1-develop Nov 9, 2017
okorshenko pushed a commit that referenced this pull request Nov 9, 2017
@ishakhsuvarov
MAGETWO-83500: Fix issue with special characters in email subject #12115
0133b0d
@ihor-sviziev ihor-sviziev removed the Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch label Nov 10, 2017
@ihor-sviziev ihor-sviziev deleted the fix-issue-with-cpecial-characters-in-email-subject branch November 10, 2017 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@okorshenko okorshenko

Labels
bugfix Component: Sales Progress: accept Release Line: 2.1
Projects
None yet
Milestone
November 2017
Development

Successfully merging this pull request may close these issues.
6 participants
@ihor-sviziev @magento-team @okorshenko @magento-engcom-team @Andrewb89 @arnie1947