Update AbstractBackend.php #12120
Merged
Update AbstractBackend.php #12120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello guys, when the validation message is returned, the attribute code is displayed. That prevents a better translation for other languages, has been adjusted to return the label instead of the attribute code. Adjustments on lines 234, 241, 254.
|
|
|
@hewersonfreitas tests failed. Could you adjust your code or tests (if needed)? |
okorshenko
pushed a commit
that referenced
this pull request
Nov 23, 2017
magento-engcom-team
pushed a commit
that referenced
this pull request
Feb 8, 2018
- fixed failed tests
|
I accidentally deleted hewersonfreitas: patch-1, could it revert? I can't display on my github that you contribute to the project |
|
@hewersonfreitas pr is accepted and merged, you could safely remove branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello guys, when the validation message is returned, the attribute code is displayed.
That prevents a better translation for other languages, has been adjusted to return the label instead of the attribute code.
Adjustments on lines 234, 241, 254.
Description
Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist