Fixed invalid parameter type in phpdoc block in Topmenu class#12495
Merged
Conversation
dmanners
suggested changes
Nov 30, 2017
| * Add identity | ||
| * | ||
| * @param array $identity | ||
| * @param string $identity |
Contributor
There was a problem hiding this comment.
technically this method accepts both strings and arrays as in_array will work with both and we never actually check the type. Since this class is noted with the @api I think it would be best to update the typehint to be string|array as we do not know how people use it.
Member
Author
There was a problem hiding this comment.
Thanks, never know that I can use array as identity.
Contributor
There was a problem hiding this comment.
I mean technically you can, not sure you should do though.
dmanners
approved these changes
Nov 30, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
addIdentitymethod accepts strings, not an array.See the usage:
Contribution checklist