Skip to content

Case mismatch #12516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 1, 2017
Merged

Case mismatch #12516

merged 2 commits into from
Dec 1, 2017

Conversation

lfluvisotto
Copy link
Contributor

@lfluvisotto lfluvisotto commented Dec 1, 2017

Case mismatch

Description

Case mismatch in class usage
Case mismatch in function/method call

Fixed Issues (if relevant)

N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@ishakhsuvarov ishakhsuvarov self-assigned this Dec 1, 2017
@ishakhsuvarov ishakhsuvarov added this to the December 2017 milestone Dec 1, 2017
@ishakhsuvarov
Copy link
Contributor

@lfluvisotto This fix looks like a nice improvement to the code quality. Would you like to implement some kind of static test to enforce correct naming in the future?

@lfluvisotto
Copy link
Contributor Author

I am using PhpStorm with the directive idea.case.sensitive.fs=true and tools from https://github.com/phpqa/phpqa.github.io

@okorshenko okorshenko merged commit 6655666 into magento:2.2-develop Dec 1, 2017
okorshenko pushed a commit that referenced this pull request Dec 1, 2017
@lfluvisotto
Copy link
Contributor Author

@ishakhsuvarov so sorry the delayed response.
I will have a look on that. > "Would you like to implement some kind of static test to enforce correct naming in the future?"

@ishakhsuvarov
Copy link
Contributor

@lfluvisotto Thanks

@lfluvisotto lfluvisotto deleted the case-mismatch branch November 22, 2019 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants