Skip to content

Added correction for og:type content value #12530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 4, 2017
Merged

Added correction for og:type content value #12530

merged 1 commit into from
Dec 4, 2017

Conversation

atishgoswami
Copy link
Contributor

@atishgoswami atishgoswami commented Dec 3, 2017

Description

Added correction to the og:type meta tag content value.

Before:
<meta property="og:type" content="og:product" />

After:
<meta property="og:type" content="product" />

References:
Facebook Open Graph
Pinterest

Fixed Issues (if relevant)

None, code improvement

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@orlangur orlangur self-assigned this Dec 4, 2017
@orlangur orlangur added this to the December 2017 milestone Dec 4, 2017
Copy link
Contributor

@orlangur orlangur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @atishgoswami, no other invalid values of og:type present all over the codebase.

@okorshenko okorshenko merged commit 448bfec into magento:2.2-develop Dec 4, 2017
@atishgoswami atishgoswami deleted the og-type-content-correction branch December 4, 2017 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants