Skip to content

Add customer login url from Customer Url model to checkout config so … #12630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 22, 2017

Conversation

quisse
Copy link

@quisse quisse commented Dec 11, 2017

…it contains the referer url if necessary

Description

Use the url created in the customer model instead of creating a new one with the url builder. The current way isn't adding a referrer parameter when required

Fixed Issues (if relevant)

  1. Referer is not added to login url in checkout config #12627: Referer is not added to login url in checkout config

Manual testing scenarios

  1. Enable Redirect Customer to Account Dashboard after Logging in in the Magento backend.
  2. Retrieve the login url from the window.checkout object (key is customerLoginUrl)

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Dec 12, 2017
@omiroshnichenko omiroshnichenko self-assigned this Dec 13, 2017
@omiroshnichenko
Copy link
Contributor

Please, review comments in #12631

@magento-team magento-team merged commit 4350858 into magento:2.2-develop Dec 22, 2017
magento-team pushed a commit that referenced this pull request Dec 22, 2017
@magento-engcom-team magento-engcom-team added Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line labels Dec 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Progress: accept Release Line: 2.2 Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants