Add error message if not logged in for adding products to wishlist #12681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
December 13, 2017 19:29
…nto2 into wishlist_add_message
…nto2 into wishlist_add_message
…nto2 into wishlist_add_message
ishakhsuvarov
requested changes
Dec 14, 2017
| @@ -30,26 +30,34 @@ class Plugin | |||
| protected $config; | |||
|
|
|||
| /** | |||
| * @var \Magento\Framework\App\Response\RedirectInterface | |||
| * @var \Magento\Framework\Message\ManagerInterface $messageManager | |||
There was a problem hiding this comment.
Looks like this change was done unintentionally.
| /** | ||
| * @var \Magento\Framework\Message\ManagerInterface $messageManager | ||
| */ | ||
| protected $messageManager; |
There was a problem hiding this comment.
Please use only private properties for core code as usage of inheritance is not encouraged.
ishakhsuvarov
approved these changes
Dec 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When you add a product to the wishlist and you're not logged in you're redirected to the login page without any warning. In this PR I've added short warning why you're redirect to the login page.
Manual testing scenarios
Add product to wishlist without logging in.
Contribution checklist