Skip to content

magento/magento2#12719: Use full name in welcome message #12738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 22, 2017
Merged

magento/magento2#12719: Use full name in welcome message #12738

merged 1 commit into from
Dec 22, 2017

Conversation

xpoback
Copy link
Contributor

@xpoback xpoback commented Dec 15, 2017 •
edited
Loading

Description

Using full customer name instead of only first name in welcome message

Fixed Issue

  1. Welcome message is shown with customer's first and last names after confirming account #12719: Welcome message is shown with customer's first and last names after confirming account

Manual testing scenarios

  1. Log in into a customer account in frontend

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Dec 15, 2017 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team magento-engcom-team added bugfix Component: Customer mageconf Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release labels Dec 15, 2017
vkublytskyi
vkublytskyi reviewed Dec 15, 2017
View reviewed changes
dev/tests/functional/tests/app/Magento/Checkout/Test/Constraint/AssertCartPerCustomer.php
sprintf(self::WELCOME_MESSAGE, $customer->getFirstname()),
sprintf(
self::WELCOME_MESSAGE,
$customer->getFirstname() . ' ' . $customer->getLastname()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This assertion may lead to false negative result in a future as full name has more complex logic then just first and last name (see \Magento\Customer\Helper\View::getCustomerName)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vkublytskyi You're right, but the fixtures are autogenerated - such complex logic is just not expected there.

@ishakhsuvarov ishakhsuvarov self-assigned this Dec 18, 2017
@ishakhsuvarov ishakhsuvarov added this to the December 2017 milestone Dec 18, 2017
@okorshenko okorshenko mentioned this pull request Dec 22, 2017
Closed
@magento-team magento-team merged commit 6b9c39c into magento:2.2-develop Dec 22, 2017
magento-team pushed a commit that referenced this pull request Dec 22, 2017
MAGETWO-85785: #12719: Use full name in welcome message #12738
70d3636
@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Dec 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkublytskyi vkublytskyi vkublytskyi left review comments

@ishakhsuvarov ishakhsuvarov ishakhsuvarov approved these changes

Assignees

@ishakhsuvarov ishakhsuvarov

Labels
bugfix Component: Customer Fixed in 2.2.x The issue has been fixed in 2.2 release line Progress: accept Release Line: 2.2 Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release
Projects
None yet
Milestone
December 2017
Development

Successfully merging this pull request may close these issues.
6 participants
@xpoback @magento-cicd2 @vkublytskyi @ishakhsuvarov @magento-team @magento-engcom-team