Skip to content

magento/magento2#12439 Newsletter subscription success email not sent… #12751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 22, 2017
Merged

magento/magento2#12439 Newsletter subscription success email not sent… #12751

merged 1 commit into from
Dec 22, 2017

Conversation

Styopchik
Copy link

@Styopchik Styopchik commented Dec 15, 2017 •
edited
Loading

… after confirmation

added sendSuccessMessage

Description

Added $this->sendConfirmationSuccessEmail(); to confirm method of \Magento\Newsletter\Model\Subscriber.

Fixed Issues (if relevant)

#12439 Newsletter subscription success email not sent after confirmation

Manual testing scenarios

  1. Change configuration under Stores > Configuration > Customers > Newsletter > Subscription Options > Need to Confirm to Yes
  2. Sign up for Newsletter on frontend
  3. Follow confirmation link in email
  4. Confirmation email should arrive

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added Fixed in 2.3.x The issue has been fixed in 2.3 release line mageconf Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Dec 15, 2017
@ishakhsuvarov
Copy link
Contributor

@Styopchik Thank you for updating.

@Styopchik
Copy link
Author

@ishakhsuvarov you are welcome

@miguelbalparda miguelbalparda self-assigned this Dec 18, 2017
@miguelbalparda miguelbalparda added this to the December 2017 milestone Dec 18, 2017
@miguelbalparda
Copy link
Contributor

This one is going to be merged soon, thanks for your contribution!
Backports welcome.

@okorshenko okorshenko mentioned this pull request Dec 22, 2017
Closed
@magento-team magento-team merged commit c4e4168 into magento:2.2-develop Dec 22, 2017
magento-team pushed a commit that referenced this pull request Dec 22, 2017
MAGETWO-85783: #12439 Newsletter subscription success email not sent… #…
f045f37 
…12751
@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Dec 22, 2017
@Styopchik Styopchik deleted the #12439 branch May 17, 2018 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@miguelbalparda miguelbalparda

Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Progress: accept Release Line: 2.2 Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
December 2017
Development

Successfully merging this pull request may close these issues.
5 participants
@Styopchik @ishakhsuvarov @miguelbalparda @magento-team @magento-engcom-team