Skip to content

Add missing preference for ObjectManager\ConfigInterface in integrati… #12845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 3, 2018
Merged

Add missing preference for ObjectManager\ConfigInterface in integrati… #12845

merged 1 commit into from
Jan 3, 2018

Conversation

schmengler
Copy link
Contributor

@schmengler schmengler commented Dec 21, 2017

…on tests

Description

A missing preference caused failures in integration tests as soon as the object manager config interface occured in the dependency graph of an instantiated class.

Fixed Issues (if relevant)

  1. "Cannot instantiate interface Magento\Framework\Interception\ObjectManager\ConfigInterface" error in integration tests #12844: "Cannot instantiate interface Magento\Framework\Interception\ObjectManager\ConfigInterface" error in integration tests

Manual testing scenarios

See Issue

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@mzeis mzeis self-assigned this Dec 21, 2017
@mzeis mzeis added this to the December 2017 milestone Dec 21, 2017
@mzeis
Copy link
Contributor

mzeis commented Dec 21, 2017

Thanks Fabian for this pull request! As I leave tomorrow morning for Christmas holidays I'm afraid I will only be able to finish the processing after the holidays (even when it's just a small change).

I hope you understand. Happy Christmas! 🎄

@schmengler
Copy link
Contributor Author

No problem, I'm enjoying my holidays too without work 😄 Happy new year!

@mzeis
Copy link
Contributor

mzeis commented Jan 6, 2018

Thanks again @schmengler for your fix. It has been merged into 2.2-develop!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixed in 2.2.x The issue has been fixed in 2.2 release line Progress: accept Release Line: 2.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants