Throw ValidationException for invalid xml #12859
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures the offending file path is output in the error
report.
Description
Currently, when malformed
$content
is fed into\Magento\Config\Model\Config\Structure\Reader::processingDocument
and unhandled\Exception
is thrown. The output fails to indicate the location of the offending file, example:The proposed change catches the
\Exception
and throws\Magento\Framework\Config\Dom\ValidationException
instead. This still causes the application to report an error, but logs the offending file in the error report, example:Manual testing scenarios
system.xml
file, such as a duplicate closing tag.system.xml
file in the error report.Contribution checklist