Skip to content

Remove unused if statement in order invoice save #12887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 3, 2018
Merged

Remove unused if statement in order invoice save #12887

merged 1 commit into from
Jan 3, 2018

Conversation

JeroenVanLeusden
Copy link
Member

Description

$shippingResponse is undefined in scope.

Fixed Issues (if relevant)

  1. None

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Remove unused if statement in order invoice save
f282ad1 
$shippingResponse is undefined in scope.
@JeroenVanLeusden JeroenVanLeusden mentioned this pull request Dec 27, 2017
Merged
4 tasks
@ishakhsuvarov ishakhsuvarov self-assigned this Dec 27, 2017
@ishakhsuvarov ishakhsuvarov added this to the December 2017 milestone Dec 27, 2017
magento-team pushed a commit that referenced this pull request Jan 3, 2018
@ishakhsuvarov
MAGETWO-86035: Remove unused if statement in order invoice save #12887
51e4805
@magento-team magento-team merged commit f282ad1 into magento:2.2-develop Jan 3, 2018
@JeroenVanLeusden JeroenVanLeusden deleted the patch-1 branch February 4, 2018 12:45
@paales paales added Partner: Reach Digital Pull Request is created by partner Reach Digital and removed Partner: Reach Digital Pull Request is created by partner Reach Digital labels May 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ishakhsuvarov ishakhsuvarov

Labels
Partner: Reach Digital Pull Request is created by partner Reach Digital Progress: accept Release Line: 2.2
Projects
None yet
Milestone
December 2017
Development

Successfully merging this pull request may close these issues.
4 participants
@JeroenVanLeusden @magento-team @paales @ishakhsuvarov