Skip to content

Fix issue 12894: Can't remove State is required for all countries #12917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 8, 2018

Conversation

vasilii-b
Copy link

Description

In this PR was fixed a minor issue in System Configuration page reported in #12894.
It is about State options -> State is required for which do not allow you to leave the multiselect empty (have no required states for any countries).

image

Fixed Issues

  1. Can't remove State is required for all countries #12894: Can't remove State is required for all countries

Manual testing scenarios

  1. Login to admin page
  2. Navigate to Stores > Configuration > General
  3. In the fieldset State is Required for disable all options.
  4. Click to save
  5. Fieldset State is Required for has no any selected values

@magento-engcom-team magento-engcom-team added Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Dec 29, 2017
@miguelbalparda miguelbalparda self-assigned this Dec 29, 2017
@miguelbalparda miguelbalparda added this to the December 2017 milestone Dec 29, 2017
@miguelbalparda
Copy link
Contributor

miguelbalparda commented Dec 29, 2017

This is going to be merged soon, thanks and welcome @vasilii-b!

@vasilii-b
Copy link
Author

@miguelbalparda yw :)

@okorshenko okorshenko modified the milestones: December 2017, January 2018 Jan 8, 2018
@magento-team magento-team merged commit 4f91566 into magento:2.2-develop Jan 8, 2018
@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Jan 8, 2018
@vasilii-b vasilii-b deleted the issue-12894 branch January 9, 2018 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Progress: accept Release Line: 2.2 Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants