-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Issues #10559 - Extend swatch using mixins (M2.2) #12929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
For Magento 2.2
querySelectorAll - Selector cannot be integer
magento#12929 (cherry picked from commit 10c9417)
magento#12929 (cherry picked from commit 8441fbc)
Thanks a lot @srenon for your fix! By the way, it seems like this file have the same issue on the product view form for the price-box mixin support: magento2/app/code/Magento/Catalog/view/frontend/templates/product/view/form.phtml Lines 42 to 57 in e177f45
I applied the same method you did for the price-box on the listing which seems to work. For those wondering, I replaced it with this: <script type="text/x-magento-init">
{
"[data-role=priceBox][data-price-box=product-id-<?= $block->escapeHtml($_product->getId()) ?>]": {
"priceBox": {
"priceConfig": <?= /* @escapeNotVerified */ $block->getJsonConfig() ?>
}
}
}
</script> |
Description
Fixed Issues (if relevant)
#10559: Extending swatch functionality using javascript mixins does not work in Safari and MS Edge
Manual testing scenarios