Skip to content

[Backport #12668 into 2.3-develop] Fix for reverting stock twice for cancelled orders #12949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 11, 2018
Merged

[Backport #12668 into 2.3-develop] Fix for reverting stock twice for cancelled orders #12949

merged 1 commit into from
Jan 11, 2018

Conversation

dverkade
Copy link
Member

@dverkade dverkade commented Jan 2, 2018 •
edited by adrian-martinez-interactiv4
Loading

Description

Fix for reverting stock twice for cancelled orders:

  • Removed cataloginventory event observer restore_quote, that increased the stock when rebuilding a quote. Reverting quote inventory should be responsibility either of sales_model_service_quote_submit_failure or sales_order_item_cancel events;

Fixed Issues

This is a backport to the 2.3 develop branch of the following PR:

  1. Fix for reverting stock twice for cancelled orders #12668

Fixed Issues

  1. Cancel order and restore quote methods increase stocks twice #9969: Cancel order and restore quote methods increase stocks twice

@magento-engcom-team magento-engcom-team added bugfix Component: Payment Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Jan 2, 2018
@magento-team magento-team mentioned this pull request Jan 11, 2018
Closed
@magento-team magento-team merged commit 1055076 into magento:2.3-develop Jan 11, 2018
magento-team pushed a commit that referenced this pull request Jan 11, 2018
MAGETWO-86260: [Backport #12668 into 2.3-develop] Fix for reverting s…
fe08e29 
…tock twice for cancelled orders #12949
@magento-engcom-team magento-engcom-team added Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line labels Jan 11, 2018
@dverkade dverkade deleted the 2.3-Fix-for-reverting-stock-twice-for-cancelled-orders branch June 22, 2018 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@adrian-martinez-interactiv4 adrian-martinez-interactiv4

Labels
bugfix Community Insider: Cream community-insider-contribution Component: Payment Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Progress: accept Release Line: 2.3 Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
January 2018
Development

Successfully merging this pull request may close these issues.
4 participants
@dverkade @magento-team @adrian-martinez-interactiv4 @magento-engcom-team