-
Notifications
You must be signed in to change notification settings - Fork 9.4k
[Port to 2.3-develop] Sort configurable attribute options by sort_order #13011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
magento-team
merged 1 commit into
magento:2.3-develop
from
wardcapp:magento-2.3/patch-MAGETWO-61484
Jan 9, 2018
Merged
[Port to 2.3-develop] Sort configurable attribute options by sort_order #13011
magento-team
merged 1 commit into
magento:2.3-develop
from
wardcapp:magento-2.3/patch-MAGETWO-61484
Jan 9, 2018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When fetching configurable options using the configurable product option select builder, the sort_order of each option should be taken into account as well, making sure the desired sorting is passed to the frontend. See github issue magento#7441, internal ticket MAGETWO-61484 and PR#12420 for more on this.
The jasmine test failures (reported by Travis) do not seem to relate to the changes made and I cannot reproduce the failures locally (using the Luma theme, blank was tested as well):
Not quite sure what went wrong when Travis executed those tests. A newer PR, #13012, strangely did pass the same tests. |
magento-team
pushed a commit
that referenced
this pull request
Jan 9, 2018
…ons by sort_order #13011
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bugfix
Component: Catalog
Fixed in 2.2.x
The issue has been fixed in 2.2 release line
Fixed in 2.3.x
The issue has been fixed in 2.3 release line
Progress: accept
Release Line: 2.3
Reproduced on 2.1.x
The issue has been reproduced on latest 2.1 release
Reproduced on 2.2.x
The issue has been reproduced on latest 2.2 release
Reproduced on 2.3.x
The issue has been reproduced on latest 2.3 release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of PR #12963 to the 2.3-develop branch.
See github issue #7441, internal ticket MAGETWO-61484 and PR #12420.
Description
Resolves the issue documented in GitHub ticket #7441. A similar PR was opened before (#12963), which is now ported to the 2.3-develop branch.
Fixed Issues
Manual testing scenarios
(copied over from PR #12420, which is still valid)
Steps to reproduce
Create a configurable attribute and add two options at least.
Create a configurable product for these options.
Go to the product page and see the configurable attribute select (options).
Change attribute options sort order and flush all caches.
Go to the product page and see the configurable attribute select (options) looks like before.
Expected result:
Configurable options HAVE been reordered.
Contribution checklist